From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C3C4D44EA6 for ; Sun, 27 Nov 2022 17:34:12 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 14D5068BC15; Sun, 27 Nov 2022 19:34:09 +0200 (EET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C384368BC07 for ; Sun, 27 Nov 2022 19:34:02 +0200 (EET) Received: by mail-wm1-f45.google.com with SMTP id o30so6966049wms.2 for ; Sun, 27 Nov 2022 09:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FZjIob3Hrl3ZNsIZs1DyTLej0UGXL3HK1TdyLq+rPpM=; b=RBRmlsiEJyjDZhF0D+gjIMN6uErKm2Tk53URTkQTzDs+MC7OZOOGgiF4oaiULEuQs0 BGIl+SLBWtVGSBvd1Hhbi4g3ecrm8KcYGxfcBNrKeWNQh7CrJiCpJ0H6VKVHUUYmC9Tq LCP3Q61SdEPdt26i3a5DAReESJCX2FI4cVM3/ndaFP3Rjkg1UKk49Cmt/E+DarvnJXla 71d0MEHYIUg32S/3J+pWeNVyT4KBOWak3I6JN18CodOr2m7c3ZstASaylRVYeXLWb0ET WfucxN8ZIZ+d4N9hXZP1+mBUBEtS2zJLUrDj9Yp6dgagVdc6mrNqCcvKuQseJnL8CWo3 uqBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FZjIob3Hrl3ZNsIZs1DyTLej0UGXL3HK1TdyLq+rPpM=; b=oohMtwUTyYhgTvoLCDN/ocJ3Tr3aAnZdjF/YxYNTUrsVWBuZlp4fUltae7oed58l7X E7EwiSwNzKfwEO9OlR4dAjK74xf+PosVQbyqtQmg8UIgU2LqvwtF4G5E+BZg4E6VnSex jVpoVUmP8ao/0IrToKSyqwMC0klXJeQ5z+COy34ZB1oQIuMg8DBjbg/GXY/WTYDuyeE1 IvYCDmRGmD/mQsBknsY0wWjPjHzmv7iUArQRIl9y25e+EKuDIDO4o2Rod75rcnueYT+B 3W5Rr0JufXJvxh+J41wZnK7J594meC5+23fNbIE56EMI15j+BrdHjQyV07EsLyN8oXG2 450Q== X-Gm-Message-State: ANoB5pnbo9WR1yHcHjxE+UD+NZHJkg7xEi/2r/EFPPwmDb/t16PswYHd GECj7kDhDeZXIEd/XgeNCCjjqa5tmm2gVw== X-Google-Smtp-Source: AA0mqf7gCWYvv5VfZ3UbP5RI8Kycx3s4B+x3vQFveGY4YlWChHE48xUlApQgfcwP44rco6+V1ZIZ9w== X-Received: by 2002:a7b:cbc6:0:b0:3c6:b650:34dd with SMTP id n6-20020a7bcbc6000000b003c6b65034ddmr28677877wmi.45.1669570441860; Sun, 27 Nov 2022 09:34:01 -0800 (PST) Received: from localhost.localdomain ([46.121.212.87]) by smtp.googlemail.com with ESMTPSA id l1-20020a05600c4f0100b003c6f3f6675bsm17578104wmq.26.2022.11.27.09.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Nov 2022 09:34:01 -0800 (PST) From: Alessandro Di Nepi To: ffmpeg-devel@ffmpeg.org Date: Sun, 27 Nov 2022 19:33:44 +0200 Message-Id: <20221127173343.2577-1-alessandro.dinepi@gmail.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Alessandro Di Nepi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: The commit d7f4ad88a0df3c1339e142957bf2c40cd056b8ce introduced a race condition where the passed opaque pointer reference might be NULL, when the decoding process starts. This patch checks that vtctx has a value before accessing it. This patch fixes #10079. Signed-off-by: Alessandro Di Nepi --- libavcodec/videotoolbox.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index 1b1be8ddb4..615e2b087a 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -692,6 +692,11 @@ static void videotoolbox_decoder_callback(void *opaque, { VTContext *vtctx = opaque; + if (!vtctx) { + av_log(NULL, AV_LOG_WARNING, "vt decoder cb: vt context is null"); + return; + } + if (vtctx->frame) { CVPixelBufferRelease(vtctx->frame); vtctx->frame = NULL; -- 2.37.1 (Apple Git-137.1) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".