From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/mobiclip: Check input size before (re)allocation
Date: Fri, 18 Nov 2022 22:09:17 +0100
Message-ID: <20221118210918.3169-3-michael@niedermayer.cc> (raw)
In-Reply-To: <20221118210918.3169-1-michael@niedermayer.cc>
Fixes: Timeout
Fixes: 52566/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOBICLIP_fuzzer-4913160050311168
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
libavcodec/mobiclip.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavcodec/mobiclip.c b/libavcodec/mobiclip.c
index aca462428c..c3b2383dbc 100644
--- a/libavcodec/mobiclip.c
+++ b/libavcodec/mobiclip.c
@@ -1216,6 +1216,9 @@ static int mobiclip_decode(AVCodecContext *avctx, AVFrame *rframe,
AVFrame *frame = s->pic[s->current_pic];
int ret;
+ if (avctx->height/16 * (avctx->width/16) * 2 > 8LL*FFALIGN(pkt->size, 2))
+ return AVERROR_INVALIDDATA;
+
av_fast_padded_malloc(&s->bitstream, &s->bitstream_size,
pkt->size);
--
2.17.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-11-18 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 21:09 [FFmpeg-devel] [PATCH 1/4] avcodec/tiff: Ignore tile_count Michael Niedermayer
2022-11-18 21:09 ` [FFmpeg-devel] [PATCH 2/4] avformat/id3v2: Check taglen in read_uslt() Michael Niedermayer
2022-11-28 19:47 ` Michael Niedermayer
2022-11-18 21:09 ` Michael Niedermayer [this message]
2022-11-19 2:34 ` [FFmpeg-devel] [PATCH 3/4] avcodec/mobiclip: Check input size before (re)allocation Shiyou Yin
2022-11-28 19:46 ` Michael Niedermayer
2022-11-18 21:09 ` [FFmpeg-devel] [PATCH 4/4] avcodec/vqcdec: Check for end of input in decode_vectors() Michael Niedermayer
2022-11-18 23:03 ` Peter Ross
2022-11-19 20:04 ` Michael Niedermayer
2022-11-19 12:40 ` [FFmpeg-devel] [PATCH 1/4] avcodec/tiff: Ignore tile_count Anton Khirnov
2022-11-19 19:49 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118210918.3169-3-michael@niedermayer.cc \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git