From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 38C0344CFD for ; Tue, 15 Nov 2022 22:19:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 548CA68BDA5; Wed, 16 Nov 2022 00:19:09 +0200 (EET) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6A8CF68BD45 for ; Wed, 16 Nov 2022 00:19:03 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id C971A60006 for ; Tue, 15 Nov 2022 22:19:02 +0000 (UTC) Date: Tue, 15 Nov 2022 23:19:02 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221115221902.GE1783292@pb2> References: <20221115221657.23290-1-michael@niedermayer.cc> <20221115221657.23290-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: <20221115221657.23290-2-michael@niedermayer.cc> Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Use more unsigned intermediates X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1926959373388886098==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1926959373388886098== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WBsA/oQW3eTA3LlM" Content-Disposition: inline --WBsA/oQW3eTA3LlM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2022 at 11:16:57PM +0100, Michael Niedermayer wrote: > Same principle as previous commit, with sufficiently huge rgb2yuv table > values this produces wrong results and undefined behavior. > The unsigned produces the same incorrect results. That is probably > ok as these cases with huge values seem not to occur in any real > use case. >=20 > There are more cases but someone is refactoring them, so i didnt yet chan= ge > them. >=20 > Fixes: signed integer overflow > Signed-off-by: Michael Niedermayer > --- > libswscale/input.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) I can merge these 2 if people prefer [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --WBsA/oQW3eTA3LlM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY3QQVQAKCRBhHseHBAsP q+AOAJ9fCpJX0dbl5Au54nUdTpXjlj0LsgCfTWWl2n7838J3DC1L1s/tjPLBv3U= =LgIZ -----END PGP SIGNATURE----- --WBsA/oQW3eTA3LlM-- --===============1926959373388886098== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1926959373388886098==--