From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1751344CCE for ; Mon, 14 Nov 2022 22:21:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 34A5B68BBEE; Tue, 15 Nov 2022 00:21:44 +0200 (EET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 025BF68B779 for ; Tue, 15 Nov 2022 00:21:37 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id E72ACC0002 for ; Mon, 14 Nov 2022 22:21:36 +0000 (UTC) Date: Mon, 14 Nov 2022 23:21:36 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221114222136.GB1783292@pb2> References: <20221018123701.25002-1-anton@khirnov.net> <20221018123701.25002-14-anton@khirnov.net> <20221018215122.GC907335@pb2> <166791161719.20155.9147898559803770848@lain.khirnov.net> MIME-Version: 1.0 In-Reply-To: <166791161719.20155.9147898559803770848@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 14/20] fftools/ffmpeg_mux_init: drop a duplicated block in copy_metadata() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7666755497617136218==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7666755497617136218== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wzJLGUyc3ArbnUjN" Content-Disposition: inline --wzJLGUyc3ArbnUjN Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 08, 2022 at 01:46:57PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-10-18 23:51:22) > > On Tue, Oct 18, 2022 at 02:36:55PM +0200, Anton Khirnov wrote: > > > It does the same thing as the block right below it. > > > --- > > > fftools/ffmpeg_mux_init.c | 10 ---------- > > > 1 file changed, 10 deletions(-) > >=20 > > This seems to make a difference for > > ffmpeg -i meta.flac -map_metadata:s -1 -vcodec mpeg4 -t 0.1 -y /tmp/tm= p3x.mkv > >=20 > > The metadata in meta.flac is a bit odd though > >=20 > > Input #0, flac, from '/home/michael/videos/meta.flac': > > Metadata: > > al : Hyper fast Audio and Video encoder > > : usage: ffmpeg [options] [[infile options] -i infi= le]... {[outfile options] outfile}... > > :=20 > > : Main options: > > .... > > : -param1 E.V.. scaler param 1 > > x : =F6=E4=FC?=DF^x=B2=A4 >=20 > Is this before or after? >=20 > If I'm reading the code correctly, no metadata should be copied after my > patch, which IMO is more consistent with the docs. sorry for the delay, the metadata disappears as you describe after the patch thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --wzJLGUyc3ArbnUjN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY3K/aQAKCRBhHseHBAsP qyfaAJ48lFPwE26ctiUpWX2a3xjc/UJugQCfQasFVi4WAcQWOSJCM9y1j9p9acQ= =wULY -----END PGP SIGNATURE----- --wzJLGUyc3ArbnUjN-- --===============7666755497617136218== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7666755497617136218==--