Re: [FFmpeg-devel] [PATCH 14/20] fftools/ffmpeg_mux_init: drop a duplicated block in copy_metadata()

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1499 bytes --]

On Tue, Nov 08, 2022 at 01:46:57PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2022-10-18 23:51:22)
> > On Tue, Oct 18, 2022 at 02:36:55PM +0200, Anton Khirnov wrote:
> > > It does the same thing as the block right below it.
> > > ---
> > >  fftools/ffmpeg_mux_init.c | 10 ----------
> > >  1 file changed, 10 deletions(-)
> > 
> > This seems to make a difference for
> > ffmpeg -i meta.flac -map_metadata:s -1 -vcodec mpeg4 -t 0.1  -y /tmp/tmp3x.mkv
> > 
> > The metadata in meta.flac is a bit odd though
> > 
> > Input #0, flac, from '/home/michael/videos/meta.flac':
> >   Metadata:
> >     al              : Hyper fast Audio and Video encoder
> >                     : usage: ffmpeg [options] [[infile options] -i infile]... {[outfile options] outfile}...
> >                     : 
> >                     : Main options:
> > ....
> >                     : -param1            <double> E.V.. scaler param 1
> >     x               : öäü?ß^x²€
> 
> Is this before or after?
> 
> If I'm reading the code correctly, no metadata should be copied after my
> patch, which IMO is more consistent with the docs.

sorry for the delay, the metadata disappears as you describe after the patch

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".