From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 586E344CBE for ; Mon, 14 Nov 2022 20:32:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4631768080D; Mon, 14 Nov 2022 22:32:44 +0200 (EET) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44F8568B883 for ; Mon, 14 Nov 2022 22:32:37 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 2F50F100006 for ; Mon, 14 Nov 2022 20:32:34 +0000 (UTC) Date: Mon, 14 Nov 2022 21:32:32 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221114203232.GH1814017@pb2> References: <20221106123430.1668-1-michael@niedermayer.cc> <20221106123430.1668-3-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 3/7] avcodec/bonk: Remove special 32bit case from read_uint_max() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8356356507013810929==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8356356507013810929== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k7W93gQNhKgsYkEv" Content-Disposition: inline --k7W93gQNhKgsYkEv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 06, 2022 at 07:28:48PM +0100, Paul B Mahol wrote: > On 11/6/22, Michael Niedermayer wrote: > > This case seems not to match the reference decoder and it also > > seems not reachable > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/bonk.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > > index 04ea4def2f..fca8c246aa 100644 > > --- a/libavcodec/bonk.c > > +++ b/libavcodec/bonk.c > > @@ -136,8 +136,7 @@ static unsigned read_uint_max(BonkContext *s, uint3= 2_t > > max) > > if (max =3D=3D 0) > > return 0; > > > > - if (max >> 31) > > - return 32; > > + av_assert0(max >> 31 =3D=3D 0); > > > > for (unsigned i =3D 1; i <=3D max - value; i+=3Di) > > if (get_bits1(&s->gb)) > > -- > > 2.17.1 >=20 >=20 > Not sure, at your risk. >=20 > Test lossy mode too. piotr provided me with a larger testset including lossy files they are all unchanged will apply this and the other remaining patches. They look all correct to me, if i am wrong which is always a possibility iam human ... then you can revert whats wrong of course thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you drop bombs on a foreign country and kill a hundred thousand innocent people, expect your government to call the consequence "unprovoked inhuman terrorist attacks" and use it to justify dropping more bombs and killing more people. The technology changed, the idea is old. --k7W93gQNhKgsYkEv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY3Kl2AAKCRBhHseHBAsP qwuBAKCWer2Ox6TYweIbiU/l7VLNuQl9twCeKpxiC+fzpTwl9E/4sImOrNBve1Y= =MqUx -----END PGP SIGNATURE----- --k7W93gQNhKgsYkEv-- --===============8356356507013810929== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8356356507013810929==--