From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CBE044C97 for ; Mon, 14 Nov 2022 15:43:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 17C1668BE5F; Mon, 14 Nov 2022 17:43:03 +0200 (EET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7093368BD24 for ; Mon, 14 Nov 2022 17:42:56 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668440581; x=1699976581; h=from:to:cc:subject:date:message-id; bh=LgKvmx9LJ6mDJ+QW7afB2SNSyo3R+Mi4SIMpfxCW1PU=; b=iPlJDp7KvxnJXQfabCEnEaYu2gwjx91iHo2Yy0GqBWjmSVRLMqZJrNA0 jBa+GzFVQw4JKnkSHjCDFNI2ociIs1xwa4FBjjnOluEacRKrJRDDxudLD mVDU++s1sLey2Amhai3/BzLMWy6GRVWsaZwvclh24h57E0wcOJCh71fZ9 1YMkx4mmOsuHZv3MGIEcnQZevFPdKazqusxgUsoAbB4eom2KpMiFBgtPH MTPE+F5OzDA9rW8BIdnmc+xhpKK912CC9JIEefwEVNE33z/VOIRbglDra Iu+Q+cAH9ia+JxSTKuqZbNMC4iZwNosdxrrSi3srhT9DP6c1oifNAL7yo Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="374129818" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="374129818" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 07:42:54 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10531"; a="744187858" X-IronPort-AV: E=Sophos;i="5.96,164,1665471600"; d="scan'208";a="744187858" Received: from bionic.bj.intel.com ([172.16.183.158]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Nov 2022 07:42:52 -0800 From: bin.wang-at-intel.com@ffmpeg.org To: ffmpeg-devel@ffmpeg.org Date: Mon, 14 Nov 2022 23:20:23 +0800 Message-Id: <20221114152023.11003-1-bin.wang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH v2] libavfilter/x86/vf_convolution: fix sobel swap issue on WIN64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Wang, Bin" , Wang@ffbox0-bg.ffmpeg.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: "Wang, Bin" Signed-off-by: Wang, Bin --- libavfilter/x86/vf_convolution.asm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavfilter/x86/vf_convolution.asm b/libavfilter/x86/vf_convolution.asm index c912d56752..9ac9ef5d73 100644 --- a/libavfilter/x86/vf_convolution.asm +++ b/libavfilter/x86/vf_convolution.asm @@ -189,15 +189,16 @@ cglobal filter_sobel, 4, 15, 7, dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x %endif %if WIN64 - SWAP xmm0, xmm2 - SWAP xmm1, xmm3 + VBROADCASTSS m0, xmm2 + VBROADCASTSS m1, xmm3 mov r2q, matrixmp mov r3q, ptrmp DEFINE_ARGS dst, width, matrix, ptr, c0, c1, c2, c3, c4, c5, c6, c7, c8, r, x -%endif - movsxdifnidn widthq, widthd +%else VBROADCASTSS m0, xmm0 VBROADCASTSS m1, xmm1 +%endif + movsxdifnidn widthq, widthd pxor m6, m6 mov c0q, [ptrq + 0*gprsize] mov c1q, [ptrq + 1*gprsize] @@ -281,7 +282,7 @@ cglobal filter_sobel, 4, 15, 7, dst, width, rdiv, bias, matrix, ptr, c0, c1, c2, fmaddss xmm4, xmm5, xmm5, xmm4 sqrtps xmm4, xmm4 - fmaddss xmm4, xmm4, xmm0, xmm1 ;sum = sum * rdiv + bias + fmaddss xmm4, xmm4, xm0, xm1 ;sum = sum * rdiv + bias cvttps2dq xmm4, xmm4 ; trunc to integer packssdw xmm4, xmm4 packuswb xmm4, xmm4 -- 2.27.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".