From: Oneric <oneric@oneric.de>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH v2 1/3] avcodec/ass: fix comment
Date: Sun, 13 Nov 2022 20:57:16 +0100
Message-ID: <20221113195718.17752-2-oneric@oneric.de> (raw)
In-Reply-To: <20221113195718.17752-1-oneric@oneric.de>
There is no v4 ASS. There are versions 1 to 4 of SSA (with only v4
being supported by softsub renderers), ASS which declares itself as v4+
or v4.00+, and the rarely used v4++/v4.00++, which isn't fully supported
by libass.
As reflected by the [V4+ Styles] section header, FFmpeg uses ASS, not
SSA v4, so adjust the comment accordingly.
---
libavcodec/ass.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/ass.c b/libavcodec/ass.c
index 728cfb1ab5..fdf55f36ca 100644
--- a/libavcodec/ass.c
+++ b/libavcodec/ass.c
@@ -44,7 +44,7 @@ int ff_ass_subtitle_header_full(AVCodecContext *avctx,
"\r\n"
"[V4+ Styles]\r\n"
- /* ASSv4 header */
+ /* ASS (v4+) header */
"Format: Name, "
"Fontname, Fontsize, "
"PrimaryColour, SecondaryColour, OutlineColour, BackColour, "
--
2.30.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-11-13 19:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 19:57 [FFmpeg-devel] [PATCH v2 0/3] Some small ASS conversion fixes Oneric
2022-11-13 19:57 ` Oneric [this message]
2022-11-13 19:57 ` [FFmpeg-devel] [PATCH v2 2/3] avcodec/ass: accurately preserve colours Oneric
2022-11-13 19:57 ` [FFmpeg-devel] [PATCH v2 3/3] avcodec/ass: specify a permissive encoding Oneric
2022-11-13 20:15 ` Oneric
2022-11-13 22:14 ` Oneric
2022-11-13 20:15 ` [FFmpeg-devel] [PATCH v2 0/3] Some small ASS conversion fixes Soft Works
2022-11-13 20:27 ` Oneric
2022-11-13 21:00 ` Oneric
2022-11-13 21:03 ` Soft Works
2022-11-13 21:01 ` Soft Works
2022-11-13 21:57 ` Oneric
2022-11-14 18:52 ` Oneric
2022-11-20 0:15 ` Oneric
2022-12-01 6:01 ` Oneric
2022-12-01 12:30 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221113195718.17752-2-oneric@oneric.de \
--to=oneric@oneric.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git