From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A523543B0E for ; Thu, 10 Nov 2022 19:43:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C3EA368BC2E; Thu, 10 Nov 2022 21:43:37 +0200 (EET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A1FA968B896 for ; Thu, 10 Nov 2022 21:43:30 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 8FA9AFF803 for ; Thu, 10 Nov 2022 19:43:29 +0000 (UTC) Date: Thu, 10 Nov 2022 20:43:27 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221110194327.GC1814017@pb2> References: <20221106123430.1668-1-michael@niedermayer.cc> <20221106123430.1668-6-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 6/7] avcodec/bonk: Check step against overflow X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4843743518448278744==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4843743518448278744== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q7MaAb+MMjzLKrXy" Content-Disposition: inline --Q7MaAb+MMjzLKrXy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 06, 2022 at 07:25:35PM +0100, Paul B Mahol wrote: > On 11/6/22, Michael Niedermayer wrote: > > No testcase > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/bonk.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > > index 37ad7854b6..f2427de4f1 100644 > > --- a/libavcodec/bonk.c > > +++ b/libavcodec/bonk.c > > @@ -180,6 +180,8 @@ static int intlist_read(BonkContext *s, int *buf, i= nt > > entries, int base_2_part) > > if (!dominant) > > n_zeros +=3D steplet; > > > > + if (step > INT32_MAX*8LL/9 + 1) > > + return AVERROR_INVALIDDATA; > > step +=3D step / 8; > > } else if (steplet > 0) { > > int actual_run =3D read_uint_max(s, steplet - 1); > > -- > > 2.17.1 >=20 > probably ok will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Whats the most studid thing your enemy could do ? Blow himself up Whats the most studid thing you could do ? Give up your rights and freedom because your enemy blew himself up. --Q7MaAb+MMjzLKrXy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY21UXwAKCRBhHseHBAsP q7iQAJ0Rn88qMwNXeb66QyFE5aq0mtsyEQCeIBLpYTGg055AFLCuuVFEVPPF4O0= =BlVl -----END PGP SIGNATURE----- --Q7MaAb+MMjzLKrXy-- --===============4843743518448278744== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4843743518448278744==--