From: Thierry Foucu <tfoucu@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Thierry Foucu <tfoucu@gmail.com>
Subject: [FFmpeg-devel] [PATCH] motion_est: fixed signed_integer_overflow when computing score
Date: Wed, 9 Nov 2022 14:31:32 -0800
Message-ID: <20221109223132.1795504-1-tfoucu@gmail.com> (raw)
---
libavcodec/motion_est.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c
index d17ffe42b4..95978d95dd 100644
--- a/libavcodec/motion_est.c
+++ b/libavcodec/motion_est.c
@@ -1571,7 +1571,7 @@ void ff_estimate_b_frame_motion(MpegEncContext * s,
type= CANDIDATE_MB_TYPE_BACKWARD_I;
}
- score= ((unsigned)(score*score + 128*256))>>16;
+ score= ((uint64_t)(score)*(uint64_t)(score) + 128*256)>>16;
c->mc_mb_var_sum_temp += score;
s->mc_mb_var[mb_y*s->mb_stride + mb_x] = score; //FIXME use SSE
}
--
2.38.1.493.g58b659f92b-goog
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2022-11-09 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 22:31 Thierry Foucu [this message]
2022-11-11 18:15 ` James Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109223132.1795504-1-tfoucu@gmail.com \
--to=tfoucu@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git