Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/bonk: steplet cannot become negative
Date: Sun,  6 Nov 2022 13:34:30 +0100
Message-ID: <20221106123430.1668-7-michael@niedermayer.cc> (raw)
In-Reply-To: <20221106123430.1668-1-michael@niedermayer.cc>

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/bonk.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c
index f2427de4f1..c775ed5ddf 100644
--- a/libavcodec/bonk.c
+++ b/libavcodec/bonk.c
@@ -169,8 +169,7 @@ static int intlist_read(BonkContext *s, int *buf, int entries, int base_2_part)
             return AVERROR_INVALIDDATA;
 
         if (!get_bits1(&s->gb)) {
-            if (steplet < 0)
-                break;
+            av_assert0(steplet >= 0);
 
             if (steplet > 0) {
                 bits[x  ].bit   = dominant;
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-11-06 12:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06 12:34 [FFmpeg-devel] [PATCH 1/7] avcodec/bonk: Use unsigned in predictor_calc_error() to avoid undefined overflows Michael Niedermayer
2022-11-06 12:34 ` [FFmpeg-devel] [PATCH 2/7] avcodec/bonk: Simplify read_uint_max() Michael Niedermayer
2022-11-06 18:30   ` Paul B Mahol
2022-11-10 19:42     ` Michael Niedermayer
2022-11-06 12:34 ` [FFmpeg-devel] [PATCH 3/7] avcodec/bonk: Remove special 32bit case from read_uint_max() Michael Niedermayer
2022-11-06 18:28   ` Paul B Mahol
2022-11-14 20:32     ` Michael Niedermayer
2022-11-14 20:58       ` Paul B Mahol
2022-11-06 12:34 ` [FFmpeg-devel] [PATCH 4/7] avcodec/bonk: actual_run seems not able to become negative Michael Niedermayer
2022-11-06 18:27   ` Paul B Mahol
2022-11-06 12:34 ` [FFmpeg-devel] [PATCH 5/7] avcodec/bonk: step cannot become 0 without overflowing which is undefined Michael Niedermayer
2022-11-06 18:26   ` Paul B Mahol
2022-11-06 12:34 ` [FFmpeg-devel] [PATCH 6/7] avcodec/bonk: Check step against overflow Michael Niedermayer
2022-11-06 18:25   ` Paul B Mahol
2022-11-10 19:43     ` Michael Niedermayer
2022-11-06 12:34 ` Michael Niedermayer [this message]
2022-11-06 18:22   ` [FFmpeg-devel] [PATCH 7/7] avcodec/bonk: steplet cannot become negative Paul B Mahol
2022-11-06 18:31 ` [FFmpeg-devel] [PATCH 1/7] avcodec/bonk: Use unsigned in predictor_calc_error() to avoid undefined overflows Paul B Mahol
2022-11-10 19:41   ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221106123430.1668-7-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git