From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4864D439AE for ; Wed, 2 Nov 2022 19:36:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E0D9268BE99; Wed, 2 Nov 2022 21:36:55 +0200 (EET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ECCE268BD10 for ; Wed, 2 Nov 2022 21:36:49 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e1kZ86hi1mtvyr19J9vjVEa7rCDGI8tVoIllhpQwb5e9nstuUSqHTHXym7FaIkuNocRUP8cNSvNKB+3HvZ8CXqaQao9kHi/pc3WAE8gHEHOw4Sj67uL52ZawW/NdXB08bqQPTYrSt/kusRcqSkZfJDOm8cWi1HBN5fVgcjpSmIfxBE0+7CMp7J3Vfu6DTIIDpJfROjfshXS8y7Gb1gf+BuynBeNCHZyMEaKRrG2ayJq19zdnBl7gVb+YtpOKVWSCxfTInkbLX+NtVc/xXjEfJYsCGPcFJwsSLtc11sgyaVlTXF9Xy5TctNbc2hZpVLxS6ChcRzYfL/q4T2UI0wz7Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ioVLTocXQ5lPGYoEhgRHNpQU2wLXlxGrNvPtPjM4+0=; b=Fs8pE+M2ANlLnHC6LgfMY4a566KHfttaDk0me/BCwbP2QTKGcYGSyl4YW6aQ1dAVLrFiwk7ANxDUtTB8+7t+zF5G8bWMVT9gZdcCYT8cmZFLNICWaUzKTcAuCJ/8V+wTOvgo9l8askliT0y4momQ75u71qhNHq3KsD1Z3oZuOmZrmvOvkBAGCBOsmVNHWeOdha34rqeEz0JCrvkRfnmToqB+zBP+Cfhdi8w/+cngIq1sd0qPZReHYOeS3nEYcIiMnJDz7EOsMptc1CChH5dLPTPO6/cFtzeL8W1bKfyEd9Mcvj2Rgao3YMgDrM2asiWj/4gxct96tyQhXbg+kSpFTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ffmpeg.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ioVLTocXQ5lPGYoEhgRHNpQU2wLXlxGrNvPtPjM4+0=; b=W692bNU5qS3Ea0+OsHWT3JPvtp41xg24l9LMvhYeID4sbLwGGn8ibGSgebL4cBU8EEGzytWtEziy3WCJMU2eTlzl4oYILAhkH68m/TmK1rnTuaK5ee2aCytmgSvp+ZfUK0yKk/U+59L0v2q/fcKxVU1DI8GMJ1rPbA88HX0plS4= Received: from BN9PR03CA0103.namprd03.prod.outlook.com (2603:10b6:408:fd::18) by SA1PR12MB7342.namprd12.prod.outlook.com (2603:10b6:806:2b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Wed, 2 Nov 2022 19:36:46 +0000 Received: from BN8NAM11FT008.eop-nam11.prod.protection.outlook.com (2603:10b6:408:fd:cafe::86) by BN9PR03CA0103.outlook.office365.com (2603:10b6:408:fd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.21 via Frontend Transport; Wed, 2 Nov 2022 19:36:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT008.mail.protection.outlook.com (10.13.177.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Wed, 2 Nov 2022 19:36:46 +0000 Received: from ruijing-ubuntu-pc.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 2 Nov 2022 14:36:43 -0500 From: Ruijing Dong To: Date: Wed, 2 Nov 2022 15:35:53 -0400 Message-ID: <20221102193553.214197-1-ruijing.dong@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221101023218.667352-1-ruijing.dong@amd.com> References: <20221101023218.667352-1-ruijing.dong@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT008:EE_|SA1PR12MB7342:EE_ X-MS-Office365-Filtering-Correlation-Id: e6830c58-d526-4691-a771-08dabd099410 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G42FziqCxXcZ7Lk5cdXrMGUtKmqlwxo6vKFLi7f2z4l1DrbzfnHCyPigghtdZVJcnVwev4Wt4kHD4+fn86SOPK3rs0GfGlJAtejiPg8jCoFx206QFG3TSfnRSlcEG3t2Q1WMYL3TWS4LdFRDlNY87fSXN+M7RK9eX0aGIxEEiavK/Ht9ESmmAKIqb9ku1UI1+tpQ/AJOIHcIw6DmMMOfMrx5XxNC2vsQCz4nDQQ2A+zU+XTxDizkuCmRoC3o//wTy1vRlJWdZC4/z+5qJi6VFexAAyC6otlZdy0KEYdkWK+LK1BUoZhKbb4axuDO5b0Lzn/wqID+5O+/t+pGFLqN6F3vxEnSLKJyjhHQ1utLFznnTMsJTmmVsAHePPur8gFwIAdqOb4ylzMkUx+hfQjluWR9miJb5c3dmepSwyR0rqDJSWkNVNDz1DU5k8kfTXe95222dM7XGCpOjCsBCVn2Vut7DQs9aRtKSQBV6j77TxnDmtlGwd1kqjKhzU2nmGyGOfCyGHENAToaTgCecg1M+eqYWQ+PEGoHGlzXn7+oVAxr7++96P+965PddwcRv7XayqeFpQ7/mAToQTObUL5PqeZ2NBKeTSiLpW+KnGF4WhfGQ+Qt/H5madq4FMsuzOWpUML7LZhuq3hzp1nzO1ojNmUtWHKe3aJM0Q5FsVIKn/z1rzn65P5kzzdkB68rXT9eFu0ccVR7cdn/W5graOUI6M3Vk7KX3YX7CV93Wmp2mBLQy962PlMKHL6R1igDeKHM X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(39860400002)(396003)(136003)(451199015)(40470700004)(46966006)(36840700001)(8936002)(44832011)(40480700001)(5660300002)(316002)(54906003)(478600001)(70206006)(966005)(7696005)(83380400001)(41300700001)(8676002)(6916009)(70586007)(81166007)(356005)(36860700001)(336012)(6666004)(82740400003)(426003)(26005)(1076003)(2616005)(16526019)(186003)(4326008)(47076005)(86362001)(40460700003)(82310400005)(2906002)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 19:36:46.2352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6830c58-d526-4691-a771-08dabd099410 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT008.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7342 Subject: [FFmpeg-devel] [PATCH v3] avcodec/av1_vaapi: fixed a decoding corruption issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: ruijing.dong@amd.com, fei.w.wang@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: In av1_spec.pdf page 38/669, there is a sentence below: if ( frame_type == KEY_FRAME && show_frame ) { for ( i = 0; i < NUM_REF_FRAMES; i++) { RefValid[ i ] = 0 ...... } ...... } This shows that the condition of invalidating current DPB frames should be the coming frame_type is KEY_FRAME plus show_frame is equal to 1. Otherwise, some of the frames in sequence after KEY_FRAME still refer to the reference frames before KEY_FRAME, and if these before KEY_FRAME reference frames were invalidated, these frames could not find their reference frames, and it could cause image corruption. Mesa fix is in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19386 Signed-off-by: Ruijing Dong --- update: re-organize commit message and title libavcodec/vaapi_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c index 63374c31c9..d0339b2705 100644 --- a/libavcodec/vaapi_av1.c +++ b/libavcodec/vaapi_av1.c @@ -274,7 +274,7 @@ static int vaapi_av1_start_frame(AVCodecContext *avctx, }; for (int i = 0; i < AV1_NUM_REF_FRAMES; i++) { - if (pic_param.pic_info_fields.bits.frame_type == AV1_FRAME_KEY) + if (pic_param.pic_info_fields.bits.frame_type == AV1_FRAME_KEY && frame_header->show_frame) pic_param.ref_frame_map[i] = VA_INVALID_ID; else pic_param.ref_frame_map[i] = ctx->ref_tab[i].valid ? -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".