From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4EACE449DB for ; Mon, 31 Oct 2022 15:47:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4F99E68BE27; Mon, 31 Oct 2022 17:47:17 +0200 (EET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D826668BD9F for ; Mon, 31 Oct 2022 17:47:10 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glARO3jV00lc6LEJ8bCi2a8shpGav/6KjgHKRISZOhauYdEJiKzo3WV+mBSxqt9oHjrLdgxiqgejboL77tj/msrCQKVjOPKz4qV9lSSdsDZsLdeFburN7ahKbsQ4oftlOSyTE44Fglb/YC7ntL3t4yw/UCx9WDK9mQmudgmDnxGkDKKrHfbrQ90/OLIrGJTiV2KhmCWkwu7Z0Lmgo2/aV5uxr1nH+RwreZvUDT2DLyhHcBnyI/KfpR2wGDtqo2bLJfSurnLaLZ4YFYxNUbVrM6Jl2j7IvF4UUUQZk7ZiOIjhmhHyZsPs1a1WpCKHwt5M1Hxmf91yHBFMUvCrL9ZeAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sGqRtE2S7O2EHWZ5oI6jJwFpyRvljxca2thYOqgKJgI=; b=bYLzNYsTWpfdTidR7E0TXQK1D2Qqhc2hMWy8ZrVbd688cfOCvG+YYlUCBSh161NJoivdZ6n4iz798IWm+lO0eqxRFUdJaveuEUcWa7SQixqgKaCcYKtt9P0/DvvAwlSDjA6mdpEETuGUlaz36lyPn4Ce2k68u9iGDRs1GLM7W1n1RpVzHwzxTQ6iMZO4cVwY/Jo6XfSTUuwlg/MYOm8oM2OvpSRqN0hShhK+m16uipFWNJv01nkgd/sNpQ7XXIIJrS5Mz7RJ5TdFa2jZedGjuWBAFxyUFOxzxNr4hq87lfymUzOkCuPOeNbKhVE294+c877beyd1GAOemkfJiydD2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ffmpeg.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGqRtE2S7O2EHWZ5oI6jJwFpyRvljxca2thYOqgKJgI=; b=oVVl3gtIfDWkzIuF51rtxALvYpCM5+0KbbkOPv6sJ16MuHE7kvXGkJPTSXLXpFBnwXcoLHsQUutTvgwJ8NnGHV2B25CSX7A8nZNuasfA5jjbPdBwgXUXRC14UDgru2ehKTOHwE27/6ud761JDzpvBUQuM8lffQBXJIzWoG8RTcc= Received: from BN0PR04CA0187.namprd04.prod.outlook.com (2603:10b6:408:e9::12) by SN7PR12MB7129.namprd12.prod.outlook.com (2603:10b6:806:2a1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct 2022 15:47:06 +0000 Received: from BN8NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e9:cafe::c8) by BN0PR04CA0187.outlook.office365.com (2603:10b6:408:e9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19 via Frontend Transport; Mon, 31 Oct 2022 15:47:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT067.mail.protection.outlook.com (10.13.177.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5769.14 via Frontend Transport; Mon, 31 Oct 2022 15:47:05 +0000 Received: from ruijing-ubuntu-pc.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 31 Oct 2022 10:47:05 -0500 From: Ruijing Dong To: Date: Mon, 31 Oct 2022 11:46:52 -0400 Message-ID: <20221031154652.101396-1-ruijing.dong@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT067:EE_|SN7PR12MB7129:EE_ X-MS-Office365-Filtering-Correlation-Id: 318d935d-ff3a-4310-8589-08dabb572976 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nXEs3C60+guRRjigQwrXLzuW9LP/etJprfC6SD3ZRjI2k+NZH+h3CxTgAGYE+QJL8VL0SvL8aFIo4yhcyUpeLbnV3G1qIg6kWXrVK/UwRFxN59Ohsx2i3oUUMv4d4gzQjde3jpTC2hRkarW0nE5KjVbyRmyABVTN+kWDUQbXgb8NK4Lnmrxti7zfkeAdqLcVZYl4G1tLvOiyK36Ne2rAPlz3J2AQUhuXQl9ntO1zs2Vce2BbqPxo3LOtvBOja3OftgGD6Ei2PcwO36S5U6jVpHrMVj8aOXnvFiFpGcXwEur3G+xxQP0YUOFrnVpnP78MvGS3YwVuXzA5tWGO0cNasS26Ew3e48PfDU8gwL0goQAKAuDDN7brw/7cKbIGq80Af7Rz/GEzPds1Z64IrkKiNuXWssqGTWKsPenlCxrHzFf4NVAuN270fiKz4qXIsW8JZmmT3x+JUk+pj/I5sUPvrEwK1WyVal7g2qm8rGtrWAqAL7KXJrMsbHHoXj/GOh9NrXvuoqczfaRSQKwpVMmHBHBA3rrujjgb0dTYmnS2NYeuefHv1hqnkC0r2HHGOyU6nLqEAEUu6dBEUju/3NOnVy3+/ayvKNL63S04XgxGpgvuiCgBL1hgKesNdwlwfWL/8jzum+s0jGItOpA1R6fHRuUWttZAdVvyWDvSNvQ+xduHa39+thILdFcjSFH5LEQfAwwCNughnvnqPE4OUQShMjX5Kq8XbbdHUrkyghPI0UB/ajDsKrOF4moCn+lVeYfB X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(346002)(396003)(136003)(451199015)(46966006)(40470700004)(36840700001)(356005)(82310400005)(81166007)(40480700001)(86362001)(36756003)(41300700001)(40460700003)(26005)(4326008)(7696005)(8676002)(2616005)(1076003)(8936002)(186003)(5660300002)(6666004)(966005)(44832011)(478600001)(70586007)(70206006)(16526019)(36860700001)(6916009)(316002)(47076005)(82740400003)(426003)(83380400001)(336012)(2906002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 15:47:05.8059 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 318d935d-ff3a-4310-8589-08dabb572976 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7129 Subject: [FFmpeg-devel] [PATCH] avcodec/av1: fixed an vaapi decoding corruption issue X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: fei.w.wang@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: [problem] When decoding an av1 bitstream, it shows image corruption in the middle of the bitstream around key frames. [analysis] In av1_spec.pdf page 38/669, there is a sentence below: if ( frame_type == KEY_FRAME && show_frame ) { for ( i = 0; i < NUM_REF_FRAMES; i++) { RefValid[ i ] = 0 ...... } ...... } This shows that the condition of invalidating current DPB frames should be the coming frame_type is KEY_FRAME plus show_frame is equal to 1. Otherwise, some of the frames in sequence after KEY_FRAME still refer to the reference frames before KEY_FRAME, and if these before KEY_FRAME reference frames were invalidated, these frames could not find their reference frames, and it could cause image corruption. [solution] Add show_frame flag as another condition to co-determine when to invalidate DPB reference frames. Mesa fix is in https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19386 cc: Fei Wang Signed-off-by: Ruijing Dong --- libavcodec/vaapi_av1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vaapi_av1.c b/libavcodec/vaapi_av1.c index 63374c31c9..d0339b2705 100644 --- a/libavcodec/vaapi_av1.c +++ b/libavcodec/vaapi_av1.c @@ -274,7 +274,7 @@ static int vaapi_av1_start_frame(AVCodecContext *avctx, }; for (int i = 0; i < AV1_NUM_REF_FRAMES; i++) { - if (pic_param.pic_info_fields.bits.frame_type == AV1_FRAME_KEY) + if (pic_param.pic_info_fields.bits.frame_type == AV1_FRAME_KEY && frame_header->show_frame) pic_param.ref_frame_map[i] = VA_INVALID_ID; else pic_param.ref_frame_map[i] = ctx->ref_tab[i].valid ? -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".