From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 705C0448C5 for ; Sun, 30 Oct 2022 19:39:54 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6C1768BD3A; Sun, 30 Oct 2022 21:39:50 +0200 (EET) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 751CA68B9B7 for ; Sun, 30 Oct 2022 21:39:44 +0200 (EET) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 901B020007 for ; Sun, 30 Oct 2022 19:39:43 +0000 (UTC) Date: Sun, 30 Oct 2022 20:39:42 +0100 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221030193942.GC1814017@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] aacdec: convert to lavu/tx and support fixed-point 960-sample decoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1159418408776225187==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1159418408776225187== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KN5l+BnMqAQyZLvT" Content-Disposition: inline --KN5l+BnMqAQyZLvT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2022 at 11:46:58PM +0200, Lynne wrote: > This patch replaces the transform used in AAC with lavu/tx and removes > the limitation on only being able to decode 960-sample files > with the float decoder. > This commit also removes a whole bunch of unnecessary and slow > lifting steps the decoder did to compensate for the poor accuracy > of the old integer transformation code. >=20 > Overall float decoder speedup on Zen 3 for 64kbps: 32% >=20 > Patch attached. >=20 > Note: lavu/tx's PFA 960pt transform currently has a bug that'll get fixed > by my next patchset. The naive transforms are unaffected and may > be used to test 960pt fixed-point decoding. > configure | 4 - > libavcodec/aac.h | 27 +++++---- > libavcodec/aac_defines.h | 4 - > libavcodec/aacdec.c | 4 - > libavcodec/aacdec_fixed.c | 5 + > libavcodec/aacdec_template.c | 106 +++++++++++++----------------= ------- > libavcodec/aacsbr.c | 1=20 > libavcodec/aacsbr_fixed.c | 1=20 > libavcodec/mips/aacdec_mips.c | 4 - > libavcodec/sinewin_fixed_tablegen.c | 3 + > libavcodec/sinewin_fixed_tablegen.h | 6 ++ > 11 files changed, 74 insertions(+), 91 deletions(-) > 941b6d4662dd9808266b80fbafb5f003a734a415 0001-aacdec-convert-to-lavu-tx-= and-support-fixed-point-96.patch > From 95625b470fb61676e838310dc0108eb648f972a3 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Fri, 28 Oct 2022 21:36:10 +0200 > Subject: [PATCH] aacdec: convert to lavu/tx and support fixed-point 960-s= ample > decoding >=20 > This patch replaces the transform used in AAC with lavu/tx and removes > the limitation on only being able to decode 960-sample files > with the float decoder. > This commit also removes a whole bunch of unnecessary and slow > lifting steps the decoder did to compensate for the poor accuracy > of the old integer transformation code. >=20 > Overall float decoder speedup on Zen 3 for 64kbps: 32% This needs a update to fate checksums here: make: *** [fate-filter-meta-4560-rotate0] Error 1 make: *** [fate-prores-gray] Error 1 make: *** [fate-autorotate] Error 1 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many that live deserve death. And some that die deserve life. Can you give it to them? Then do not be too eager to deal out death in judgement. For even the very wise cannot see all ends. -- Gandalf --KN5l+BnMqAQyZLvT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY17S9gAKCRBhHseHBAsP q5f0AJ9xgUweLOWozU0nKmLlY/QSICiLcwCeOK/6PbQaq0NHoRjzf2oBU9zfdNs= =LUhb -----END PGP SIGNATURE----- --KN5l+BnMqAQyZLvT-- --===============1159418408776225187== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1159418408776225187==--