From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 36DE140537 for ; Sun, 23 Oct 2022 15:35:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6F8CE68BC56; Sun, 23 Oct 2022 18:35:25 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA37C68BA9A for ; Sun, 23 Oct 2022 18:35:18 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id E4BD5C0004 for ; Sun, 23 Oct 2022 15:35:17 +0000 (UTC) Date: Sun, 23 Oct 2022 17:35:17 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221023153517.GD4048598@pb2> References: <20221022210226.2200-1-jamrial@gmail.com> <20221022210226.2200-2-jamrial@gmail.com> MIME-Version: 1.0 In-Reply-To: <20221022210226.2200-2-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aac_ac3_parser: don't fill stream info in the sync function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5072622114608127370==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5072622114608127370== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GyRA7555PLgSTuth" Content-Disposition: inline --GyRA7555PLgSTuth Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 22, 2022 at 06:02:23PM -0300, James Almer wrote: > Have it only find frame boundaries. The stream props will then be filled = once > we have an assembled frame. >=20 > Signed-off-by: James Almer > --- > libavcodec/aac_ac3_parser.c | 63 +++++++++++++++++++++++++++++-------- > libavcodec/aac_ac3_parser.h | 12 +------ > libavcodec/aac_parser.c | 7 +---- > libavcodec/ac3_parser.c | 16 +--------- > 4 files changed, 53 insertions(+), 45 deletions(-) i probably forgot something but this breaks: --- ./tests/ref/fate/adtstoasc_ticket3715 2022-10-22 10:37:36.046518037 +02= 00 +++ tests/data/fate/adtstoasc_ticket3715 2022-10-23 17:32:17.096459090 +0200 @@ -1,4 +1,4 @@ -29ef0632a8eb5c336bf45a1d5076626e *tests/data/fate/adtstoasc_ticket3715.mov +4110be924e21846d0e174fac679b062e *tests/data/fate/adtstoasc_ticket3715.mov 33324 tests/data/fate/adtstoasc_ticket3715.mov #extradata 0: 2, 0x00340022 #tb 0: 1/44100 Test adtstoasc_ticket3715 failed. Look at tests/data/fate/adtstoasc_ticket3= 715.err for details. tests/Makefile:306: recipe for target 'fate-adtstoasc_ticket3715' failed make: *** [fate-adtstoasc_ticket3715] Error 1 [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate statistics in a paper in physics you will never get a job again. If you fake or manipulate statistics in a paper in medicin you will get a job for life at the pharma industry. --GyRA7555PLgSTuth Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY1VfLgAKCRBhHseHBAsP q1rWAJwLlPr2Ero1LPOGY+XLnDxx+ZZ2qgCgmXm1uusk20c7EYLVIFugg2dtvX0= =fiJd -----END PGP SIGNATURE----- --GyRA7555PLgSTuth-- --===============5072622114608127370== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5072622114608127370==--