From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 895944261B for ; Fri, 21 Oct 2022 18:46:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C43F368BEA7; Fri, 21 Oct 2022 21:46:16 +0300 (EEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A3D3F68BE56 for ; Fri, 21 Oct 2022 21:46:10 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id D0A0F40002 for ; Fri, 21 Oct 2022 18:46:09 +0000 (UTC) Date: Fri, 21 Oct 2022 20:46:08 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221021184608.GA4048598@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 24/24] avcodec/mpegvideo: Don't use ScanTable where unnecessary X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3822521321407866210==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3822521321407866210== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 20, 2022 at 07:24:36PM +0200, Andreas Rheinhardt wrote: > For the intra_[hv]_scantables, only ScanTable.permutated > is used, so one only needs to keep that. [...] > diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c > index 8e6e35b927..bf499a2206 100644 > --- a/libavcodec/mpeg4videoenc.c > +++ b/libavcodec/mpeg4videoenc.c > @@ -175,7 +175,7 @@ static inline int decide_ac_pred(MpegEncContext *s, i= nt16_t block[6][64], > ac_val1[i + 8] =3D level; > } > } > - st[n] =3D s->intra_h_scantable.permutated; > + st[n] =3D s->intra_h_scantable; > } else { > const int xy =3D s->mb_x - 1 + s->mb_y * s->mb_stride; > /* left prediction */ > @@ -197,7 +197,7 @@ static inline int decide_ac_pred(MpegEncContext *s, i= nt16_t block[6][64], > ac_val1[i + 8] =3D block[n][s->idsp.idct_permutation= [i]]; > } > } > - st[n] =3D s->intra_v_scantable.permutated; > + st[n] =3D s->intra_v_scantable; Iam thinking that replacing=20 s->intra_v_scantable.permutated by intra_v_scantable is semantically feeling inferrior to calling it permutated_intra_v_scantable or something like that The same probably applies to te other patches too iam not happy about the long name but having consistent naming between scantables (as in the spec) and scantables permutated for idct optimizations could improve readability of the code thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If the United States is serious about tackling the national security threat= s=20 related to an insecure 5G network, it needs to rethink the extent to which = it values corporate profits and government espionage over security.-Bruce Schn= eier --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY1Lo6gAKCRBhHseHBAsP q7RJAJ9Pb6KFzYVx/Do/U3QNAqx2Qj23HACdHP1hUgmIW1WeUJqTQv/5DgoV78Y= =zqe6 -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd-- --===============3822521321407866210== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3822521321407866210==--