From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 36C6343162 for ; Thu, 20 Oct 2022 19:33:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 62E9B68BE17; Thu, 20 Oct 2022 22:33:40 +0300 (EEST) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE7A668B9A5 for ; Thu, 20 Oct 2022 22:33:33 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id EAC361C0004 for ; Thu, 20 Oct 2022 19:33:32 +0000 (UTC) Date: Thu, 20 Oct 2022 21:33:31 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221020193331.GB2149876@pb2> References: <406d03fabf0bcf44fbfc894cf9960e3ad3947caf.1666229366.git.pross@xvid.org> MIME-Version: 1.0 In-Reply-To: <406d03fabf0bcf44fbfc894cf9960e3ad3947caf.1666229366.git.pross@xvid.org> Subject: Re: [FFmpeg-devel] [PATCHv2 1/4] avcodec/svq1: fix interframe mean VLC symbols X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============1491187075305020127==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============1491187075305020127== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rS8CxjVDS/+yyDmU" Content-Disposition: inline --rS8CxjVDS/+yyDmU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 20, 2022 at 12:29:53PM +1100, Peter Ross wrote: > Fixes ticket #128. >=20 > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped > in our SVQ1 implementation, resulting in visible artifacts for some video= s. > This patch unswaps the order of these two symbols. >=20 > The most noticable example of the artiacts caused by this error can be ob= served in > https://trac.ffmpeg.org/attachment/ticket/128/svq1_set.7z '352_288_k_50.m= ov'. > The artifacts are not observed when using the reference decoder > (QuickTime 7.7.9 x86 binary). >=20 > As a result of this patch, the reference data for the fate-svq1 test > ($SAMPLES/svq1/marymary-shackles.mov) must be modified. For this file, our > decoder output is now bitwise identical to the reference decoder. I have > tested patch with various other samples and they are all now bitwise iden= tical. >=20 > The SVQ1 encoder also produces different output because of this change, so > the the vsynth test reference data has also been updated. The order of the patches should be different because with this first the encoder and decoder behavior changes and no detection / id is=20 updated or used yet ideally one should be able to checkout any revission on git master and not generate files that do not decode correctly.=20 And files generated from this will get misdetected as old FFmpeg later if its first thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --rS8CxjVDS/+yyDmU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY1GiiwAKCRBhHseHBAsP q91gAKCE5PH5iusd0+GxrbYitRgJvZROPQCfQURueXfvKbg26DEPkTwVPdZatCQ= =ZVcU -----END PGP SIGNATURE----- --rS8CxjVDS/+yyDmU-- --===============1491187075305020127== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============1491187075305020127==--