From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C5A7744637 for ; Thu, 20 Oct 2022 19:27:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C3A5B68BE12; Thu, 20 Oct 2022 22:27:02 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2126568BD56 for ; Thu, 20 Oct 2022 22:26:56 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 134B0E0006 for ; Thu, 20 Oct 2022 19:26:54 +0000 (UTC) Date: Thu, 20 Oct 2022 21:26:53 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221020192653.GA2149876@pb2> References: <406d03fabf0bcf44fbfc894cf9960e3ad3947caf.1666229366.git.pross@xvid.org> <48a2b0b2ccefd79444b467e7d69527028ee5f3cb.1666229366.git.pross@xvid.org> MIME-Version: 1.0 In-Reply-To: <48a2b0b2ccefd79444b467e7d69527028ee5f3cb.1666229366.git.pross@xvid.org> Subject: Re: [FFmpeg-devel] [PATCHv2 3/4] avcodec/svq1enc: output ident string in extradata field X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2286255092779719445==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2286255092779719445== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 20, 2022 at 12:30:33PM +1100, Peter Ross wrote: > This will enable the acurate identification of FFmpeg produced > SVQ1 streams, should there be new bugs found in the encoder. > --- > libavcodec/svq1enc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c > index 9bd5a04368..6aacaef88d 100644 > --- a/libavcodec/svq1enc.c > +++ b/libavcodec/svq1enc.c > @@ -41,6 +41,7 @@ > #include "svq1.h" > #include "svq1encdsp.h" > #include "svq1enc_cb.h" > +#include "version.h" > =20 > #include "libavutil/avassert.h" > #include "libavutil/frame.h" > @@ -628,6 +629,14 @@ static av_cold int svq1_encode_init(AVCodecContext *= avctx) > =20 > ff_h263_encode_init(&s->m); // mv_penalty > =20 > + if (!(s->avctx->flags & AV_CODEC_FLAG_BITEXACT)) { > + avctx->extradata =3D av_malloc(sizeof(LIBAVCODEC_IDENT)); > + if (!avctx->extradata) > + return AVERROR(ENOMEM); > + memcpy(avctx->extradata, LIBAVCODEC_IDENT, sizeof(LIBAVCODEC_IDE= NT)); > + avctx->extradata_size =3D sizeof(LIBAVCODEC_IDENT); This could still store the "Lavc" without the version # I thought we did that more consistently but it seems only some encoders do it like aac: libavcodec/aacenc.c- const int bitexact =3D avctx->flags & AV_CODEC_FLAG= _BITEXACT; libavcodec/aacenc.c: const char *aux_data =3D bitexact ? "Lavc" : LIBAVC= ODEC_IDENT; thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong. --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY1Gg9AAKCRBhHseHBAsP q81gAJ4p5/6lKdfZKhjOP9TIz5AlSaHy0wCfee+V3hcyvrB/mqnJqtxYF9V3d7s= =iCZK -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7-- --===============2286255092779719445== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2286255092779719445==--