From: Anton Khirnov <anton@khirnov.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 02/20] fftools/ffmpeg_demux: add demuxer private data Date: Tue, 18 Oct 2022 14:36:43 +0200 Message-ID: <20221018123701.25002-2-anton@khirnov.net> (raw) In-Reply-To: <20221018123701.25002-1-anton@khirnov.net> Move InputFile.loop into it. --- fftools/ffmpeg.h | 1 - fftools/ffmpeg_demux.c | 37 +++++++++++++++++++++++++++---------- 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 085a775a43..35410ec4a1 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -434,7 +434,6 @@ typedef struct InputFile { int eof_reached; /* true if eof reached */ int eagain; /* true if last read attempt returned EAGAIN */ int ist_index; /* index of first stream in input_streams */ - int loop; /* set number of times input stream should be looped */ int64_t duration; /* actual duration of the longest stream in a file at the moment when looping happens */ AVRational time_base; /* time base of the duration */ diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index d2b0bc9a6d..f92500abf9 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -45,6 +45,13 @@ static const char *const opt_name_hwaccel_devices[] = {"hwaccel_device static const char *const opt_name_hwaccel_output_formats[] = {"hwaccel_output_format", NULL}; static const char *const opt_name_autorotate[] = {"autorotate", NULL}; +typedef struct Demuxer { + InputFile f; + + /* number of times input stream should be looped */ + int loop; +} Demuxer; + typedef struct DemuxMsg { AVPacket *pkt; int looping; @@ -53,6 +60,11 @@ typedef struct DemuxMsg { int repeat_pict; } DemuxMsg; +static Demuxer *demuxer_from_ifile(InputFile *f) +{ + return (Demuxer*)f; +} + static void report_new_stream(InputFile *file, const AVPacket *pkt) { AVStream *st = file->ctx->streams[pkt->stream_index]; @@ -84,8 +96,9 @@ static void ifile_duration_update(InputFile *f, InputStream *ist, } } -static int seek_to_start(InputFile *ifile) +static int seek_to_start(Demuxer *d) { + InputFile *ifile = &d->f; AVFormatContext *is = ifile->ctx; InputStream *ist; int ret; @@ -127,8 +140,8 @@ static int seek_to_start(InputFile *ifile) } } - if (ifile->loop > 0) - ifile->loop--; + if (d->loop > 0) + d->loop--; return ret; } @@ -195,7 +208,8 @@ static void ts_fixup(InputFile *ifile, AVPacket *pkt, int *repeat_pict) static void *input_thread(void *arg) { - InputFile *f = arg; + Demuxer *d = arg; + InputFile *f = &d->f; AVPacket *pkt; unsigned flags = f->non_blocking ? AV_THREAD_MESSAGE_NONBLOCK : 0; int ret = 0; @@ -216,12 +230,12 @@ static void *input_thread(void *arg) continue; } if (ret < 0) { - if (f->loop) { + if (d->loop) { /* signal looping to the consumer thread */ msg.looping = 1; ret = av_thread_message_queue_send(f->in_thread_queue, &msg, 0); if (ret >= 0) - ret = seek_to_start(f); + ret = seek_to_start(d); if (ret >= 0) continue; @@ -320,6 +334,7 @@ static int init_input_thread(int i) { int ret; InputFile *f = input_files[i]; + Demuxer *d = demuxer_from_ifile(f); if (f->thread_queue_size <= 0) f->thread_queue_size = (nb_input_files > 1 ? 8 : 1); @@ -332,7 +347,7 @@ static int init_input_thread(int i) if (ret < 0) return ret; - if (f->loop) { + if (d->loop) { int nb_audio_dec = 0; for (int i = 0; i < f->nb_streams; i++) { @@ -350,7 +365,7 @@ static int init_input_thread(int i) } } - if ((ret = pthread_create(&f->thread, NULL, input_thread, f))) { + if ((ret = pthread_create(&f->thread, NULL, input_thread, d))) { av_log(NULL, AV_LOG_ERROR, "pthread_create failed: %s. Try to increase `ulimit -v` or decrease `ulimit -s`.\n", strerror(ret)); ret = AVERROR(ret); goto fail; @@ -720,6 +735,7 @@ static void dump_attachment(AVStream *st, const char *filename) int ifile_open(OptionsContext *o, const char *filename) { + Demuxer *d; InputFile *f; AVFormatContext *ic; const AVInputFormat *file_iformat = NULL; @@ -923,7 +939,8 @@ int ifile_open(OptionsContext *o, const char *filename) /* dump the file content */ av_dump_format(ic, nb_input_files, filename, 0); - f = ALLOC_ARRAY_ELEM(input_files, nb_input_files); + d = allocate_array_elem(&input_files, sizeof(*d), &nb_input_files); + f = &d->f; f->ctx = ic; f->index = nb_input_files - 1; @@ -936,7 +953,7 @@ int ifile_open(OptionsContext *o, const char *filename) f->nb_streams = ic->nb_streams; f->rate_emu = o->rate_emu; f->accurate_seek = o->accurate_seek; - f->loop = o->loop; + d->loop = o->loop; f->duration = 0; f->time_base = (AVRational){ 1, 1 }; -- 2.35.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-18 12:38 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-18 12:36 [FFmpeg-devel] [PATCH 01/20] fftools/ffmpeg_opt: move opening input files to ffmpeg_demux.c Anton Khirnov 2022-10-18 12:36 ` Anton Khirnov [this message] 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 03/20] fftools/ffmpeg: drop init_input_threads() Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 04/20] fftools/ffmpeg: move closing the input file into a separate function Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 05/20] fftools/ffmpeg: drop free_input_threads() Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 06/20] fftools/ffmpeg: move threading fields from InputFile to Demuxer Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 07/20] fftools/ffmpeg: move duration/time_base " Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 08/20] fftools/ffmpeg_demux: do not log to the demuxer context Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 09/20] fftools/ffmpeg: move nb_streams_warn from InputFile to Demuxer Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 10/20] fftools/ffmpeg_demux: log when the demuxer thread terminates Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 11/20] fftools/ffmpeg: factor out copying metadata/chapters from of_open() Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 12/20] fftools/ffmpeg_mux_init: avoid modifying OptionsContext.chapters_input_file Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 13/20] fftools/ffmpeg_mux_init: constify metadata specifier arguments Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 14/20] fftools/ffmpeg_mux_init: drop a duplicated block in copy_metadata() Anton Khirnov 2022-10-18 21:51 ` Michael Niedermayer 2022-11-08 12:46 ` Anton Khirnov 2022-11-14 9:24 ` Anton Khirnov 2022-11-14 22:21 ` Michael Niedermayer 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 15/20] fftools/ffmpeg_mux_init: stop using OptionsContext as storage " Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 16/20] fftools/ffmpeg_mux_init: stop modifying some OptionsContext fields Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 17/20] fftools/ffmpeg_mux_init: move code creating streams into a new function Anton Khirnov 2022-10-18 12:36 ` [FFmpeg-devel] [PATCH 18/20] fftools/ffmpeg_mux_init: stop modifying OptionsContext.*_disable Anton Khirnov 2022-10-18 12:37 ` [FFmpeg-devel] [PATCH 19/20] fftools/ffmpeg_demux: stop modifying OptionsContext Anton Khirnov 2022-10-18 12:37 ` [FFmpeg-devel] [PATCH 20/20] fftools/ffmpeg_[de]mux: constify all uses of OptionsContext Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221018123701.25002-2-anton@khirnov.net \ --to=anton@khirnov.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git