From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9FD84444E8 for ; Thu, 13 Oct 2022 22:22:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8B58068BD75; Fri, 14 Oct 2022 01:22:13 +0300 (EEST) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BB1796808C9 for ; Fri, 14 Oct 2022 01:22:07 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id CD50A100003 for ; Thu, 13 Oct 2022 22:22:06 +0000 (UTC) Date: Fri, 14 Oct 2022 00:22:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221013222205.GC1970738@pb2> References: <20221013210505.GA1970738@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8035839728420037348==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8035839728420037348== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rQ2U398070+RC21q" Content-Disposition: inline --rQ2U398070+RC21q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 13, 2022 at 11:23:33PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Hi > >=20 > > On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: > >> codec_id is always AV_CODEC_ID_MPEG4 in this file. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/mpeg4videodec.c | 6 ++---- > >> 1 file changed, 2 insertions(+), 4 deletions(-) > > [...] > >> @@ -3084,7 +3083,6 @@ int ff_mpeg4_workaround_bugs(AVCodecContext *avc= tx) > >> ctx->divx_version, ctx->divx_build, s->divx_packed ? "= p" : ""); > >> =20 > >> if (CONFIG_MPEG4_DECODER && ctx->xvid_build >=3D 0 && > >> - s->codec_id =3D=3D AV_CODEC_ID_MPEG4 && > >=20 > > should the CONFIG_MPEG4_DECODER check be removed too ? > >=20 >=20 > This file is also compiled if the MPEG-4 parser or the H.263 decoder is > enabled (hence if any of the H.263 decoder family is enabled); the > former is probably done because of ff_mpeg4_pred_ac() which is used by > msmpeg4dec.c (this is the only exception to what I wrote in the commit > message; will amend it). The latter could be solved by moving the code > common to mpeg4-decoder and parser out into a file of its own, say > mpeg4_parse.c. I pondered doing that; would you have any objections to > it? It would allow to cut down on the crazy list of requirements of the > mpeg4 parser. really, you are doing this factorization, you decide which way it makes most sense. Id just say something if i see something that "feels" wrong here it was just me seeing te compile time check and you saying its always AV_CODEC_ID_MPEG4. Maybe you could word the commit messsage more verbosely=20 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin --rQ2U398070+RC21q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY0iPhQAKCRBhHseHBAsP q8QiAJ47w1EvU+M2mRrWUe4cSsi+Sp4QggCcD6r4F+cKFaWh+Qhkvx0T2S+4viQ= =ebCp -----END PGP SIGNATURE----- --rQ2U398070+RC21q-- --===============8035839728420037348== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8035839728420037348==--