From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C01F0444E3 for ; Thu, 13 Oct 2022 21:05:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CFD7568BD04; Fri, 14 Oct 2022 00:05:13 +0300 (EEST) Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [217.70.178.231]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6685168BAC0 for ; Fri, 14 Oct 2022 00:05:07 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 76E43100005 for ; Thu, 13 Oct 2022 21:05:06 +0000 (UTC) Date: Thu, 13 Oct 2022 23:05:05 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221013210505.GA1970738@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 5/6] avcodec/mpeg4videodec: Remove always-true checks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8266458897495353256==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8266458897495353256== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW" Content-Disposition: inline --ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Oct 12, 2022 at 08:06:22PM +0200, Andreas Rheinhardt wrote: > codec_id is always AV_CODEC_ID_MPEG4 in this file. >=20 > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpeg4videodec.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) [...] > @@ -3084,7 +3083,6 @@ int ff_mpeg4_workaround_bugs(AVCodecContext *avctx) > ctx->divx_version, ctx->divx_build, s->divx_packed ? "p" = : ""); > =20 > if (CONFIG_MPEG4_DECODER && ctx->xvid_build >=3D 0 && > - s->codec_id =3D=3D AV_CODEC_ID_MPEG4 && should the CONFIG_MPEG4_DECODER check be removed too ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Never trust a computer, one day, it may think you are the virus. -- Compn --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY0h9eAAKCRBhHseHBAsP qwacAJ4zLnvJuYpd7j4VCpu3G0S5D+EwigCbBLPubTbN8OR+26qIpi8pZgYzGPw= =6x8Q -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW-- --===============8266458897495353256== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8266458897495353256==--