From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 50E6B44404 for ; Mon, 10 Oct 2022 16:27:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1D5F168BD38; Mon, 10 Oct 2022 19:27:00 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F231E68BCE7 for ; Mon, 10 Oct 2022 19:26:52 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 223806000A for ; Mon, 10 Oct 2022 16:26:51 +0000 (UTC) Date: Mon, 10 Oct 2022 18:26:51 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20221010162651.GU6583@pb2> References: MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 20/20] avcodec/snowdec: Remove debug code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0960154838311344622==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0960154838311344622== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ePFeKdkqS71SfxAJ" Content-Disposition: inline --ePFeKdkqS71SfxAJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 10, 2022 at 05:13:10AM +0200, Andreas Rheinhardt wrote: > The Snow decoder checks two bits of AVCodecContext.debug > via numerical constants, not defines. One of these constants > (512) used to be equivalent to FF_DEBUG_PTS which has been > removed in 302554835e39b79b977ed60c9afe81b44590dfef > (merged in 6e69525e6984d51165de0b17b796bbc29f9dd6e7). >=20 > It is unlikely that 512 was intended to be FF_DEBUG_PTS, > as it has nothing do to with PTS; instead it makes > certain parts of the code behave like it does for keyframes > even if the current frame is not a keyframe. why not fix it instead of removing ? you can check what it did by looking at the code when it was added. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I have never wished to cater to the crowd; for what I know they do not approve, and what they approve I do not know. -- Epicurus --ePFeKdkqS71SfxAJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCY0RHywAKCRBhHseHBAsP q+8XAKCDeRBr8tD2Z1U50yQoOTUIpBNZjQCfTLrYAfATQrOt9AaQYSSvICimjgQ= =KXP3 -----END PGP SIGNATURE----- --ePFeKdkqS71SfxAJ-- --===============0960154838311344622== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0960154838311344622==--