From: Anton Khirnov <anton@khirnov.net>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 5/8] lavfi/vf_decimate: use inverse of output framerate as timebase
Date: Mon, 10 Oct 2022 18:10:52 +0200
Message-ID: <20221010161055.18948-5-anton@khirnov.net> (raw)
In-Reply-To: <20221010161055.18948-1-anton@khirnov.net>
This filter currently keeps the input timebase, but produces CFR output.
It is thus simpler to use 1/output fps as the output timebase.
Also, set output frame durations.
---
libavfilter/vf_decimate.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavfilter/vf_decimate.c b/libavfilter/vf_decimate.c
index 01404e6fec..f61e501c96 100644
--- a/libavfilter/vf_decimate.c
+++ b/libavfilter/vf_decimate.c
@@ -43,7 +43,6 @@ typedef struct DecimateContext {
AVFrame *last; ///< last frame from the previous queue
AVFrame **clean_src; ///< frame queue for the clean source
int got_frame[2]; ///< frame request flag for each input stream
- AVRational ts_unit; ///< timestamp units for the output frames
int64_t last_pts; ///< last output timestamp
int64_t start_pts; ///< base for output timestamps
uint32_t eof; ///< bitmask for end of stream
@@ -213,6 +212,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
/* push all frames except the drop */
ret = 0;
for (i = 0; i < dm->cycle && dm->queue[i].frame; i++) {
+ AVRational in_tb = ctx->inputs[INPUT_MAIN]->time_base;
if (i == drop) {
if (dm->ppsrc)
av_frame_free(&dm->clean_src[i]);
@@ -221,7 +221,8 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
AVFrame *frame = dm->queue[i].frame;
dm->queue[i].frame = NULL;
if (frame->pts != AV_NOPTS_VALUE && dm->start_pts == AV_NOPTS_VALUE)
- dm->start_pts = frame->pts;
+ dm->start_pts = av_rescale_q(frame->pts, in_tb, outlink->time_base);
+
if (dm->ppsrc) {
av_frame_free(&frame);
frame = dm->clean_src[i];
@@ -229,8 +230,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
continue;
dm->clean_src[i] = NULL;
}
- frame->pts = av_rescale_q(outlink->frame_count_in, dm->ts_unit, (AVRational){1,1}) +
+ frame->pts = outlink->frame_count_in +
(dm->start_pts == AV_NOPTS_VALUE ? 0 : dm->start_pts);
+ frame->duration = 1;
dm->last_pts = frame->pts;
ret = ff_filter_frame(outlink, frame);
if (ret < 0)
@@ -404,7 +406,7 @@ static int config_output(AVFilterLink *outlink)
fps = av_mul_q(fps, (AVRational){dm->cycle - 1, dm->cycle});
av_log(ctx, AV_LOG_VERBOSE, "FPS: %d/%d -> %d/%d\n",
inlink->frame_rate.num, inlink->frame_rate.den, fps.num, fps.den);
- outlink->time_base = inlink->time_base;
+ outlink->time_base = av_inv_q(fps);
outlink->frame_rate = fps;
outlink->sample_aspect_ratio = inlink->sample_aspect_ratio;
if (dm->ppsrc) {
@@ -414,7 +416,6 @@ static int config_output(AVFilterLink *outlink)
outlink->w = inlink->w;
outlink->h = inlink->h;
}
- dm->ts_unit = av_inv_q(av_mul_q(fps, outlink->time_base));
return 0;
}
--
2.35.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-10-10 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 16:10 [FFmpeg-devel] [PATCH 1/8] lavfi/f_drawgraph: forward input frame durations Anton Khirnov
2022-10-10 16:10 ` [FFmpeg-devel] [PATCH 2/8] lavfi/settb: rescale " Anton Khirnov
2022-10-10 16:10 ` [FFmpeg-devel] [PATCH 3/8] lavfi/vf_tinterlace: set " Anton Khirnov
2022-10-10 16:10 ` [FFmpeg-devel] [PATCH 4/8] lavfi/vf_coreimage: " Anton Khirnov
2022-10-10 16:10 ` Anton Khirnov [this message]
2022-10-10 16:10 ` [FFmpeg-devel] [PATCH 6/8] lavfi/vf_estdif: drop an unused function parameter Anton Khirnov
2022-10-10 16:10 ` [FFmpeg-devel] [PATCH 7/8] lavfi/vf_estdif: drop a redundant context variable Anton Khirnov
2022-10-10 16:10 ` [FFmpeg-devel] [PATCH 8/8] lavfi/vf_estdif: set frame durations Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010161055.18948-5-anton@khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git