From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: drop the -async option
Date: Tue, 4 Oct 2022 17:39:09 +0200
Message-ID: <20221004153909.GD2046395@pb2> (raw)
In-Reply-To: <20221004095630.869044100EF@natalya.videolan.org>
[-- Attachment #1.1: Type: text/plain, Size: 1674 bytes --]
On Tue, Oct 04, 2022 at 09:56:29AM +0000, Anton Khirnov wrote:
> ffmpeg | branch: master | Anton Khirnov <anton@khirnov.net> | Tue Aug 30 11:14:13 2022 +0200| [3d86a13b47b726e49c2d780c5f723c290e8a36b4] | committer: Anton Khirnov
>
> fftools/ffmpeg: drop the -async option
>
> It has been deprecated in favor of the aresample filter for almost 10
> years.
>
> Another thing this option can do is drop audio timestamps and have them
> generated by the encoding code or the muxer, but
> - for encoding, this can already be done with the setpts filter
> - for muxing this should almost never be done as timestamp generation by
> the muxer is deprecated, but people who really want to do this can use
> the setts bitstream filter
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3d86a13b47b726e49c2d780c5f723c290e8a36b4
> ---
>
> doc/ffmpeg.texi | 12 ------------
> fftools/ffmpeg.c | 2 +-
> fftools/ffmpeg.h | 1 -
> fftools/ffmpeg_filter.c | 10 ----------
> fftools/ffmpeg_mux.c | 3 +--
> fftools/ffmpeg_opt.c | 3 ---
> 6 files changed, 2 insertions(+), 29 deletions(-)
This breaks:
./ffmpeg -i ~/tickets/507/avdesync_cut.avi -bitexact -r 24000/1001 -t 145 -async 1 file1-old.avi
The file is no longer AV-synced after this, and iam not sure the user
will understand why
its not warning or erroring out either
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next parent reply other threads:[~2022-10-04 15:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221004095630.869044100EF@natalya.videolan.org>
2022-10-04 15:39 ` Michael Niedermayer [this message]
2022-10-12 17:29 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004153909.GD2046395@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git