From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D9C9D44A15 for ; Thu, 29 Sep 2022 23:14:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C1C9468BB6A; Fri, 30 Sep 2022 02:14:13 +0300 (EEST) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4966868B3A2 for ; Fri, 30 Sep 2022 02:14:06 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 2C14A240004 for ; Thu, 29 Sep 2022 23:14:05 +0000 (UTC) Date: Fri, 30 Sep 2022 01:14:05 +0200 From: Michael Niedermayer To: ffmpeg-devel@ffmpeg.org Message-ID: <20220929231405.GG6583@pb2> References: <20220918132124.3232741049C@natalya.videolan.org> <20220929215918.GB2046395@pb2> <20220929220325.GF6583@pb2> MIME-Version: 1.0 In-Reply-To: <20220929220325.GF6583@pb2> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mlpdec: relax channels checking X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6489551275612409139==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6489551275612409139== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r4jNezHNW2wfBox+" Content-Disposition: inline --r4jNezHNW2wfBox+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 30, 2022 at 12:03:25AM +0200, Michael Niedermayer wrote: > On Thu, Sep 29, 2022 at 11:59:18PM +0200, Michael Niedermayer wrote: > > On Sun, Sep 18, 2022 at 01:21:23PM +0000, Paul B Mahol wrote: > > > ffmpeg | branch: master | Paul B Mahol | Sat Sep 1= 7 14:08:58 2022 +0200| [adaa06581c5444c94eef72d61b8166f096e2687a] | committ= er: Paul B Mahol > > >=20 > > > avcodec/mlpdec: relax channels checking > > >=20 > > > Internal TrueHD decoder channel rematrix can mix 2 stereo substreams > > > into single mono stream. > > >=20 > > > Fixes #1726 > > >=20 > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3Dadaa0= 6581c5444c94eef72d61b8166f096e2687a > > > --- > > >=20 > > > libavcodec/mlpdec.c | 23 +---------------------- > > > 1 file changed, 1 insertion(+), 22 deletions(-) > >=20 > > This produces out of array accesses > >=20 > > Also this was never posted to the mailing list. Simply removing checks = is not > > a solution, how can that even be a solution ?! > >=20 > > please make sure you post all patches especially ones thats have not be= en tested > > very well to the mailing list >=20 > I see it was posted to the ML, iam sorry it seems i must have missed it s= omehow > its still buggy though patch which seems to fix this is attached. Didnt had as much time to write = this ATM as i would have liked ... Please review. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong. --r4jNezHNW2wfBox+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYzYmuAAKCRBhHseHBAsP q/+oAJ4/IWGb856Xtq6TnVzQIG0dJgf7oACfeY7/s1qEtqmfEPLv6PWE6j5BxMk= =d37y -----END PGP SIGNATURE----- --r4jNezHNW2wfBox+-- --===============6489551275612409139== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6489551275612409139==--