On Fri, Sep 30, 2022 at 12:03:25AM +0200, Michael Niedermayer wrote: > On Thu, Sep 29, 2022 at 11:59:18PM +0200, Michael Niedermayer wrote: > > On Sun, Sep 18, 2022 at 01:21:23PM +0000, Paul B Mahol wrote: > > > ffmpeg | branch: master | Paul B Mahol | Sat Sep 17 14:08:58 2022 +0200| [adaa06581c5444c94eef72d61b8166f096e2687a] | committer: Paul B Mahol > > > > > > avcodec/mlpdec: relax channels checking > > > > > > Internal TrueHD decoder channel rematrix can mix 2 stereo substreams > > > into single mono stream. > > > > > > Fixes #1726 > > > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=adaa06581c5444c94eef72d61b8166f096e2687a > > > --- > > > > > > libavcodec/mlpdec.c | 23 +---------------------- > > > 1 file changed, 1 insertion(+), 22 deletions(-) > > > > This produces out of array accesses > > > > Also this was never posted to the mailing list. Simply removing checks is not > > a solution, how can that even be a solution ?! > > > > please make sure you post all patches especially ones thats have not been tested > > very well to the mailing list > > I see it was posted to the ML, iam sorry it seems i must have missed it somehow > its still buggy though patch which seems to fix this is attached. Didnt had as much time to write this ATM as i would have liked ... Please review. thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.