From: Michael Niedermayer <michael@niedermayer.cc>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/mlpdec: relax channels checking
Date: Fri, 30 Sep 2022 01:14:05 +0200
Message-ID: <20220929231405.GG6583@pb2> (raw)
In-Reply-To: <20220929220325.GF6583@pb2>
[-- Attachment #1.1: Type: text/plain, Size: 1620 bytes --]
On Fri, Sep 30, 2022 at 12:03:25AM +0200, Michael Niedermayer wrote:
> On Thu, Sep 29, 2022 at 11:59:18PM +0200, Michael Niedermayer wrote:
> > On Sun, Sep 18, 2022 at 01:21:23PM +0000, Paul B Mahol wrote:
> > > ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Sat Sep 17 14:08:58 2022 +0200| [adaa06581c5444c94eef72d61b8166f096e2687a] | committer: Paul B Mahol
> > >
> > > avcodec/mlpdec: relax channels checking
> > >
> > > Internal TrueHD decoder channel rematrix can mix 2 stereo substreams
> > > into single mono stream.
> > >
> > > Fixes #1726
> > >
> > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=adaa06581c5444c94eef72d61b8166f096e2687a
> > > ---
> > >
> > > libavcodec/mlpdec.c | 23 +----------------------
> > > 1 file changed, 1 insertion(+), 22 deletions(-)
> >
> > This produces out of array accesses
> >
> > Also this was never posted to the mailing list. Simply removing checks is not
> > a solution, how can that even be a solution ?!
> >
> > please make sure you post all patches especially ones thats have not been tested
> > very well to the mailing list
>
> I see it was posted to the ML, iam sorry it seems i must have missed it somehow
> its still buggy though
patch which seems to fix this is attached. Didnt had as much time to write this
ATM as i would have liked ...
Please review.
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-09-29 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220918132124.3232741049C@natalya.videolan.org>
2022-09-29 21:59 ` Michael Niedermayer
2022-09-29 22:03 ` Michael Niedermayer
2022-09-29 23:14 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929231405.GG6583@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git