* [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter.
@ 2022-09-26 8:34 Wenbin Chen
2022-09-26 8:34 ` [FFmpeg-devel] [PATCH 2/2] libavcodec/qsvenc: Let runtime to decide targetUsage Wenbin Chen
2022-09-26 9:01 ` [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Andreas Rheinhardt
0 siblings, 2 replies; 4+ messages in thread
From: Wenbin Chen @ 2022-09-26 8:34 UTC (permalink / raw)
To: ffmpeg-devel
Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide
these parameters, so that it can choose the best parameter and ffmpeg-qsv
can keep up with runtime's update.
Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
libavcodec/qsvenc_h264.c | 4 ++--
libavcodec/qsvenc_hevc.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c
index 85826ae4be..fe777a6ae3 100644
--- a/libavcodec/qsvenc_h264.c
+++ b/libavcodec/qsvenc_h264.c
@@ -177,8 +177,8 @@ static const FFCodecDefault qsv_enc_defaults[] = {
{ "b", "1M" },
{ "refs", "0" },
// same as the x264 default
- { "g", "250" },
- { "bf", "3" },
+ { "g", "-1" },
+ { "bf", "-1" },
{ "qmin", "-1" },
{ "qmax", "-1" },
{ "trellis", "-1" },
diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
index 6ec6230999..0c5bec231d 100644
--- a/libavcodec/qsvenc_hevc.c
+++ b/libavcodec/qsvenc_hevc.c
@@ -290,7 +290,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
{ "b", "1M" },
{ "refs", "0" },
// same as the x264 default
- { "g", "248" },
+ { "g", "-1" },
{ "bf", "-1" },
{ "qmin", "-1" },
{ "qmax", "-1" },
--
2.32.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH 2/2] libavcodec/qsvenc: Let runtime to decide targetUsage
2022-09-26 8:34 [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Wenbin Chen
@ 2022-09-26 8:34 ` Wenbin Chen
2022-09-26 9:01 ` [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Andreas Rheinhardt
1 sibling, 0 replies; 4+ messages in thread
From: Wenbin Chen @ 2022-09-26 8:34 UTC (permalink / raw)
To: ffmpeg-devel
Set preset default value to MFX_TARGETUSAGE_UNKNOWN. Let runtime to
decide the targetUsage, so that ffmpeg-qsv can keep up with runtime's
update.
Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
libavcodec/qsvenc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h
index f2b7ee361f..4315463cd2 100644
--- a/libavcodec/qsvenc.h
+++ b/libavcodec/qsvenc.h
@@ -52,7 +52,7 @@
#define QSV_COMMON_OPTS \
{ "async_depth", "Maximum processing parallelism", OFFSET(qsv.async_depth), AV_OPT_TYPE_INT, { .i64 = ASYNC_DEPTH_DEFAULT }, 1, INT_MAX, VE }, \
-{ "preset", NULL, OFFSET(qsv.preset), AV_OPT_TYPE_INT, { .i64 = MFX_TARGETUSAGE_BALANCED }, MFX_TARGETUSAGE_BEST_QUALITY, MFX_TARGETUSAGE_BEST_SPEED, VE, "preset" }, \
+{ "preset", NULL, OFFSET(qsv.preset), AV_OPT_TYPE_INT, { .i64 = MFX_TARGETUSAGE_UNKNOWN }, MFX_TARGETUSAGE_UNKNOWN, MFX_TARGETUSAGE_BEST_SPEED, VE, "preset" }, \
{ "veryfast", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_TARGETUSAGE_BEST_SPEED }, INT_MIN, INT_MAX, VE, "preset" }, \
{ "faster", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_TARGETUSAGE_6 }, INT_MIN, INT_MAX, VE, "preset" }, \
{ "fast", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = MFX_TARGETUSAGE_5 }, INT_MIN, INT_MAX, VE, "preset" }, \
--
2.32.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter.
2022-09-26 8:34 [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Wenbin Chen
2022-09-26 8:34 ` [FFmpeg-devel] [PATCH 2/2] libavcodec/qsvenc: Let runtime to decide targetUsage Wenbin Chen
@ 2022-09-26 9:01 ` Andreas Rheinhardt
2022-09-26 9:04 ` Chen, Wenbin
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Rheinhardt @ 2022-09-26 9:01 UTC (permalink / raw)
To: ffmpeg-devel
Wenbin Chen:
> Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide
> these parameters, so that it can choose the best parameter and ffmpeg-qsv
> can keep up with runtime's update.
>
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
> libavcodec/qsvenc_h264.c | 4 ++--
> libavcodec/qsvenc_hevc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c
> index 85826ae4be..fe777a6ae3 100644
> --- a/libavcodec/qsvenc_h264.c
> +++ b/libavcodec/qsvenc_h264.c
> @@ -177,8 +177,8 @@ static const FFCodecDefault qsv_enc_defaults[] = {
> { "b", "1M" },
> { "refs", "0" },
> // same as the x264 default
> - { "g", "250" },
> - { "bf", "3" },
> + { "g", "-1" },
> + { "bf", "-1" },
> { "qmin", "-1" },
> { "qmax", "-1" },
> { "trellis", "-1" },
> diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
> index 6ec6230999..0c5bec231d 100644
> --- a/libavcodec/qsvenc_hevc.c
> +++ b/libavcodec/qsvenc_hevc.c
> @@ -290,7 +290,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
> { "b", "1M" },
> { "refs", "0" },
> // same as the x264 default
These comments are now wrong.
> - { "g", "248" },
> + { "g", "-1" },
> { "bf", "-1" },
> { "qmin", "-1" },
> { "qmax", "-1" },
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter.
2022-09-26 9:01 ` [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Andreas Rheinhardt
@ 2022-09-26 9:04 ` Chen, Wenbin
0 siblings, 0 replies; 4+ messages in thread
From: Chen, Wenbin @ 2022-09-26 9:04 UTC (permalink / raw)
To: FFmpeg development discussions and patches
> Wenbin Chen:
> > Unset qsv_h264 and qsv_hevc's default settings. Let runtime to decide
> > these parameters, so that it can choose the best parameter and ffmpeg-qsv
> > can keep up with runtime's update.
> >
> > Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> > ---
> > libavcodec/qsvenc_h264.c | 4 ++--
> > libavcodec/qsvenc_hevc.c | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c
> > index 85826ae4be..fe777a6ae3 100644
> > --- a/libavcodec/qsvenc_h264.c
> > +++ b/libavcodec/qsvenc_h264.c
> > @@ -177,8 +177,8 @@ static const FFCodecDefault qsv_enc_defaults[] = {
> > { "b", "1M" },
> > { "refs", "0" },
> > // same as the x264 default
> > - { "g", "250" },
> > - { "bf", "3" },
> > + { "g", "-1" },
> > + { "bf", "-1" },
> > { "qmin", "-1" },
> > { "qmax", "-1" },
> > { "trellis", "-1" },
> > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c
> > index 6ec6230999..0c5bec231d 100644
> > --- a/libavcodec/qsvenc_hevc.c
> > +++ b/libavcodec/qsvenc_hevc.c
> > @@ -290,7 +290,7 @@ static const FFCodecDefault qsv_enc_defaults[] = {
> > { "b", "1M" },
> > { "refs", "0" },
> > // same as the x264 default
>
> These comments are now wrong.
Forget these comments. I will update them in new patchset.
Thanks
Wenbin
>
> > - { "g", "248" },
> > + { "g", "-1" },
> > { "bf", "-1" },
> > { "qmin", "-1" },
> > { "qmax", "-1" },
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-26 9:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 8:34 [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Wenbin Chen
2022-09-26 8:34 ` [FFmpeg-devel] [PATCH 2/2] libavcodec/qsvenc: Let runtime to decide targetUsage Wenbin Chen
2022-09-26 9:01 ` [FFmpeg-devel] [PATCH 1/2] libavcodec/qsvenc: Let runtime to set default parameter Andreas Rheinhardt
2022-09-26 9:04 ` Chen, Wenbin
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git