* [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations
@ 2022-09-24 11:57 Marvin Scholz
2022-09-24 11:57 ` [FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Marvin Scholz @ 2022-09-24 11:57 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marvin Scholz
---
fftools/ffmpeg.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index ede0b2bd96..db7413adcd 100644
--- a/fftools/ffmpeg.h
+++ b/fftools/ffmpeg.h
@@ -686,9 +686,6 @@ extern int auto_conversion_filters;
extern const AVIOInterruptCB int_cb;
extern const OptionDef options[];
-#if CONFIG_QSV
-extern char *qsv_device;
-#endif
extern HWDevice *filter_hw_device;
extern unsigned nb_output_dumped;
@@ -716,7 +713,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame);
int ffmpeg_parse_options(int argc, char **argv);
int videotoolbox_init(AVCodecContext *s);
-int qsv_init(AVCodecContext *s);
HWDevice *hw_device_get_by_name(const char *name);
int hw_device_init_from_string(const char *arg, HWDevice **dev);
--
2.37.0 (Apple Git-136)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread* [FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration
2022-09-24 11:57 [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Marvin Scholz
@ 2022-09-24 11:57 ` Marvin Scholz
2022-09-24 12:03 ` [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Andreas Rheinhardt
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
2 siblings, 0 replies; 6+ messages in thread
From: Marvin Scholz @ 2022-09-24 11:57 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marvin Scholz
---
fftools/ffmpeg.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index db7413adcd..701a211544 100644
--- a/fftools/ffmpeg.h
+++ b/fftools/ffmpeg.h
@@ -712,8 +712,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame);
int ffmpeg_parse_options(int argc, char **argv);
-int videotoolbox_init(AVCodecContext *s);
-
HWDevice *hw_device_get_by_name(const char *name);
int hw_device_init_from_string(const char *arg, HWDevice **dev);
void hw_device_free_all(void);
--
2.37.0 (Apple Git-136)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations
2022-09-24 11:57 [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Marvin Scholz
2022-09-24 11:57 ` [FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
@ 2022-09-24 12:03 ` Andreas Rheinhardt
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
2 siblings, 0 replies; 6+ messages in thread
From: Andreas Rheinhardt @ 2022-09-24 12:03 UTC (permalink / raw)
To: ffmpeg-devel
Marvin Scholz:
> ---
> fftools/ffmpeg.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
> index ede0b2bd96..db7413adcd 100644
> --- a/fftools/ffmpeg.h
> +++ b/fftools/ffmpeg.h
> @@ -686,9 +686,6 @@ extern int auto_conversion_filters;
> extern const AVIOInterruptCB int_cb;
>
> extern const OptionDef options[];
> -#if CONFIG_QSV
> -extern char *qsv_device;
> -#endif
> extern HWDevice *filter_hw_device;
>
> extern unsigned nb_output_dumped;
> @@ -716,7 +713,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame);
> int ffmpeg_parse_options(int argc, char **argv);
>
> int videotoolbox_init(AVCodecContext *s);
> -int qsv_init(AVCodecContext *s);
>
> HWDevice *hw_device_get_by_name(const char *name);
> int hw_device_init_from_string(const char *arg, HWDevice **dev);
Patchset LGTM. Maybe also add since when these declarations are unnecessary?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations
2022-09-24 11:57 [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Marvin Scholz
2022-09-24 11:57 ` [FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
2022-09-24 12:03 ` [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Andreas Rheinhardt
@ 2022-09-24 12:20 ` Marvin Scholz
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
2022-09-24 13:33 ` [FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations Andreas Rheinhardt
2 siblings, 2 replies; 6+ messages in thread
From: Marvin Scholz @ 2022-09-24 12:20 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marvin Scholz
The code that uses these was removed in
ecee3b07cde23e05bcc6b4eaa55d860b62dbd2dc
---
fftools/ffmpeg.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index ede0b2bd96..db7413adcd 100644
--- a/fftools/ffmpeg.h
+++ b/fftools/ffmpeg.h
@@ -686,9 +686,6 @@ extern int auto_conversion_filters;
extern const AVIOInterruptCB int_cb;
extern const OptionDef options[];
-#if CONFIG_QSV
-extern char *qsv_device;
-#endif
extern HWDevice *filter_hw_device;
extern unsigned nb_output_dumped;
@@ -716,7 +713,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame);
int ffmpeg_parse_options(int argc, char **argv);
int videotoolbox_init(AVCodecContext *s);
-int qsv_init(AVCodecContext *s);
HWDevice *hw_device_get_by_name(const char *name);
int hw_device_init_from_string(const char *arg, HWDevice **dev);
--
2.37.0 (Apple Git-136)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* [FFmpeg-devel] [PATCH v2 2/2] fftools: Remove unused videotoolbox_init declaration
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
@ 2022-09-24 12:20 ` Marvin Scholz
2022-09-24 13:33 ` [FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations Andreas Rheinhardt
1 sibling, 0 replies; 6+ messages in thread
From: Marvin Scholz @ 2022-09-24 12:20 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Marvin Scholz
The code that defined videotoolbox_init was removed in
4b54818981d2783af161c2ff670b658afbdda503
---
fftools/ffmpeg.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index db7413adcd..701a211544 100644
--- a/fftools/ffmpeg.h
+++ b/fftools/ffmpeg.h
@@ -712,8 +712,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame);
int ffmpeg_parse_options(int argc, char **argv);
-int videotoolbox_init(AVCodecContext *s);
-
HWDevice *hw_device_get_by_name(const char *name);
int hw_device_init_from_string(const char *arg, HWDevice **dev);
void hw_device_free_all(void);
--
2.37.0 (Apple Git-136)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
@ 2022-09-24 13:33 ` Andreas Rheinhardt
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Rheinhardt @ 2022-09-24 13:33 UTC (permalink / raw)
To: ffmpeg-devel
Marvin Scholz:
> The code that uses these was removed in
> ecee3b07cde23e05bcc6b4eaa55d860b62dbd2dc
> ---
> fftools/ffmpeg.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
> index ede0b2bd96..db7413adcd 100644
> --- a/fftools/ffmpeg.h
> +++ b/fftools/ffmpeg.h
> @@ -686,9 +686,6 @@ extern int auto_conversion_filters;
> extern const AVIOInterruptCB int_cb;
>
> extern const OptionDef options[];
> -#if CONFIG_QSV
> -extern char *qsv_device;
> -#endif
> extern HWDevice *filter_hw_device;
>
> extern unsigned nb_output_dumped;
> @@ -716,7 +713,6 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, const AVFrame *frame);
> int ffmpeg_parse_options(int argc, char **argv);
>
> int videotoolbox_init(AVCodecContext *s);
> -int qsv_init(AVCodecContext *s);
>
> HWDevice *hw_device_get_by_name(const char *name);
> int hw_device_init_from_string(const char *arg, HWDevice **dev);
LGTM for the whole patchset.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-24 13:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-24 11:57 [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Marvin Scholz
2022-09-24 11:57 ` [FFmpeg-devel] [PATCH 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
2022-09-24 12:03 ` [FFmpeg-devel] [PATCH 1/2] fftools: Remove unused qsv declarations Andreas Rheinhardt
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 " Marvin Scholz
2022-09-24 12:20 ` [FFmpeg-devel] [PATCH v2 2/2] fftools: Remove unused videotoolbox_init declaration Marvin Scholz
2022-09-24 13:33 ` [FFmpeg-devel] [PATCH v2 1/2] fftools: Remove unused qsv declarations Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git