Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration
@ 2022-09-17 14:32 Michael Niedermayer
  2022-09-17 14:32 ` [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use Michael Niedermayer
  2022-09-17 14:45 ` [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration Paul B Mahol
  0 siblings, 2 replies; 6+ messages in thread
From: Michael Niedermayer @ 2022-09-17 14:32 UTC (permalink / raw)
  To: FFmpeg development discussions and patches

Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in type 'int'
Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/aiffdec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index 0487d3f0299..318e3ad742e 100644
--- a/libavformat/aiffdec.c
+++ b/libavformat/aiffdec.c
@@ -372,6 +372,8 @@ got_sound:
         av_log(s, AV_LOG_ERROR, "could not find COMM tag or invalid block_align value\n");
         return AVERROR_INVALIDDATA;
     }
+    if (aiff->block_duration < 0)
+        return AVERROR_INVALIDDATA;
 
     /* Now positioned, get the sound data start and end */
     avpriv_set_pts_info(st, 64, 1, st->codecpar->sample_rate);
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-09-22 15:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17 14:32 [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration Michael Niedermayer
2022-09-17 14:32 ` [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use Michael Niedermayer
2022-09-17 14:45   ` Paul B Mahol
2022-09-22 15:10     ` Michael Niedermayer
2022-09-17 14:45 ` [FFmpeg-devel] [PATCH 1/2] avformat/aiffdec: Check block_duration Paul B Mahol
2022-09-22 15:10   ` Michael Niedermayer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git