From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1CBF74475D for ; Thu, 22 Sep 2022 15:10:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CEA5268BBD2; Thu, 22 Sep 2022 18:10:43 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 09D9968B8C8 for ; Thu, 22 Sep 2022 18:10:36 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 2CF8C240005 for ; Thu, 22 Sep 2022 15:10:35 +0000 (UTC) Date: Thu, 22 Sep 2022 17:10:34 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220922151034.GJ6583@pb2> References: <20220917143209.7797-1-michael@niedermayer.cc> <20220917143209.7797-2-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/aiffdec: Use 64bit for block_duration use X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6264955484196520471==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6264955484196520471== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Re2uCLPLNzqOLVJA" Content-Disposition: inline --Re2uCLPLNzqOLVJA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 17, 2022 at 04:45:28PM +0200, Paul B Mahol wrote: > On 9/17/22, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in > > type 'int' > > Fixes: > > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-66689359797= 28896 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/aiffdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c > > index 318e3ad742e..80733e58010 100644 > > --- a/libavformat/aiffdec.c > > +++ b/libavformat/aiffdec.c > > @@ -428,7 +428,7 @@ static int aiff_read_packet(AVFormatContext *s, > > pkt->flags &=3D ~AV_PKT_FLAG_CORRUPT; > > /* Only one stream in an AIFF file */ > > pkt->stream_index =3D 0; > > - pkt->duration =3D (res / st->codecpar->block_align) * > > aiff->block_duration; > > + pkt->duration =3D (res / st->codecpar->block_align) * (int64_t) > > aiff->block_duration; > > return 0; > > } >=20 > LGTM will apply thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. U= ser questions about the command line tools should be sent to the ffmpeg-user ML. And questions about how to use libav* should be sent to the libav-user ML. --Re2uCLPLNzqOLVJA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYyx66gAKCRBhHseHBAsP q3ExAJwNTOJup125u2GFFwcYoD/Es5SCoQCghHPJkQkxTgVsESmlklqbtujh2OA= =HvwE -----END PGP SIGNATURE----- --Re2uCLPLNzqOLVJA-- --===============6264955484196520471== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6264955484196520471==--