From: Michael Niedermayer <michael@niedermayer.cc> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid Date: Sun, 18 Sep 2022 19:13:59 +0200 Message-ID: <20220918171410.31835-2-michael@niedermayer.cc> (raw) In-Reply-To: <20220918171410.31835-1-michael@niedermayer.cc> Fixes: signed integer overflow: 9223372036854775807 - -2146905566 cannot be represented in type 'long' Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-6570996594769920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavformat/mxfdec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e63e803aa56..da81fea3bc1 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -3681,6 +3681,7 @@ static int mxf_read_header(AVFormatContext *s) KLVPacket klv; int64_t essence_offset = 0; int ret; + int64_t run_in; mxf->last_forward_tell = INT64_MAX; @@ -3690,7 +3691,10 @@ static int mxf_read_header(AVFormatContext *s) } avio_seek(s->pb, -14, SEEK_CUR); mxf->fc = s; - mxf->run_in = avio_tell(s->pb); + run_in = avio_tell(s->pb); + if (run_in < 0 || run_in != (int)run_in) + return AVERROR_INVALIDDATA; + mxf->run_in = run_in; mxf_read_random_index_pack(s); -- 2.17.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-18 17:16 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-18 17:13 [FFmpeg-devel] [PATCH 01/13] avformat/flvdec: Use 64bit for sum_flv_tag_size Michael Niedermayer 2022-09-18 17:13 ` Michael Niedermayer [this message] 2022-09-20 11:07 ` [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid Tomas Härdin 2022-09-20 11:20 ` Tomas Härdin 2022-09-21 9:35 ` Michael Niedermayer 2022-09-21 13:23 ` Tomas Härdin 2022-09-21 16:16 ` Michael Niedermayer 2022-09-21 13:25 ` Tomas Härdin 2022-09-21 16:20 ` Michael Niedermayer 2022-09-21 18:56 ` Marton Balint 2022-09-22 13:29 ` Tomas Härdin 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 03/13] avformat/nutdec: Check fields Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 04/13] avformat/rmdec: check tag_size Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 05/13] avformat/sbgdec: clamp end_ts Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 06/13] avformat/sbgdec: Check ts_int in genrate_intervals Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 07/13] avformat/sdsdec: Use av_rescale() to avoid intermediate overflow in duration calculation Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 08/13] avformat/xwma: Use av_rescale() for duration computation Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 09/13] avformat/rpl: Use 64bit " Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 10/13] avformat/vividas: Check packet size Michael Niedermayer 2022-09-22 13:18 ` Anton Khirnov 2022-09-22 16:12 ` Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 11/13] avformat/spdifdec: Use 64bit to compute bit rate Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 12/13] avformat/matroskadec: Error out if a timestamp is beyond duration Michael Niedermayer 2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 13/13] avformat/westwood_vqa: Check chunk size Michael Niedermayer 2022-09-22 13:01 ` Anton Khirnov 2022-09-22 16:28 ` Michael Niedermayer 2022-09-23 21:00 ` [FFmpeg-devel] [PATCH 01/13] avformat/flvdec: Use 64bit for sum_flv_tag_size Michael Niedermayer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220918171410.31835-2-michael@niedermayer.cc \ --to=michael@niedermayer.cc \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git