Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 13/13] avformat/westwood_vqa: Check chunk size
Date: Sun, 18 Sep 2022 19:14:10 +0200
Message-ID: <20220918171410.31835-13-michael@niedermayer.cc> (raw)
In-Reply-To: <20220918171410.31835-1-michael@niedermayer.cc>

Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int'
Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_WSVQA_fuzzer-6593408795279360

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/westwood_vqa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/westwood_vqa.c b/libavformat/westwood_vqa.c
index e3d2e2668c4..bd8df5e0b34 100644
--- a/libavformat/westwood_vqa.c
+++ b/libavformat/westwood_vqa.c
@@ -274,6 +274,8 @@ static int wsvqa_read_packet(AVFormatContext *s,
                         return AVERROR(EIO);
 
                     /* the decoder expects chunks to be 16-bit aligned */
+                    if (wsvqa->vqfl_chunk_size == INT_MAX)
+                        return AVERROR_INVALIDDATA;
                     if (wsvqa->vqfl_chunk_size % 2 == 1)
                         wsvqa->vqfl_chunk_size++;
 
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  parent reply	other threads:[~2022-09-18 17:15 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 17:13 [FFmpeg-devel] [PATCH 01/13] avformat/flvdec: Use 64bit for sum_flv_tag_size Michael Niedermayer
2022-09-18 17:13 ` [FFmpeg-devel] [PATCH 02/13] avformat/mxfdec: Check run_in to fit in int and be valid Michael Niedermayer
2022-09-20 11:07   ` Tomas Härdin
2022-09-20 11:20     ` Tomas Härdin
2022-09-21  9:35       ` Michael Niedermayer
2022-09-21 13:23         ` Tomas Härdin
2022-09-21 16:16           ` Michael Niedermayer
2022-09-21 13:25         ` Tomas Härdin
2022-09-21 16:20           ` Michael Niedermayer
2022-09-21 18:56           ` Marton Balint
2022-09-22 13:29             ` Tomas Härdin
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 03/13] avformat/nutdec: Check fields Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 04/13] avformat/rmdec: check tag_size Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 05/13] avformat/sbgdec: clamp end_ts Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 06/13] avformat/sbgdec: Check ts_int in genrate_intervals Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 07/13] avformat/sdsdec: Use av_rescale() to avoid intermediate overflow in duration calculation Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 08/13] avformat/xwma: Use av_rescale() for duration computation Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 09/13] avformat/rpl: Use 64bit " Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 10/13] avformat/vividas: Check packet size Michael Niedermayer
2022-09-22 13:18   ` Anton Khirnov
2022-09-22 16:12     ` Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 11/13] avformat/spdifdec: Use 64bit to compute bit rate Michael Niedermayer
2022-09-18 17:14 ` [FFmpeg-devel] [PATCH 12/13] avformat/matroskadec: Error out if a timestamp is beyond duration Michael Niedermayer
2022-09-18 17:14 ` Michael Niedermayer [this message]
2022-09-22 13:01   ` [FFmpeg-devel] [PATCH 13/13] avformat/westwood_vqa: Check chunk size Anton Khirnov
2022-09-22 16:28     ` Michael Niedermayer
2022-09-23 21:00 ` [FFmpeg-devel] [PATCH 01/13] avformat/flvdec: Use 64bit for sum_flv_tag_size Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220918171410.31835-13-michael@niedermayer.cc \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git