* [FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t
@ 2022-09-17 9:59 remi
2022-09-17 10:46 ` Andreas Rheinhardt
0 siblings, 1 reply; 2+ messages in thread
From: remi @ 2022-09-17 9:59 UTC (permalink / raw)
To: ffmpeg-devel
From: Rémi Denis-Courmont <remi@remlab.net>
While this probably never overflows, we are better safe than sorry.
The callback prototype should probably also use ptrdiff_t or size_t but
I diggress.
---
libavcodec/vorbisdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
index 38a5367be3..9728997370 100644
--- a/libavcodec/vorbisdec.c
+++ b/libavcodec/vorbisdec.c
@@ -1581,7 +1581,7 @@ static inline int vorbis_residue_decode(vorbis_context *vc, vorbis_residue *vr,
void ff_vorbis_inverse_coupling(float *mag, float *ang, intptr_t blocksize)
{
- int i;
+ ptrdiff_t i;
for (i = 0; i < blocksize; i++) {
if (mag[i] > 0.0) {
if (ang[i] > 0.0) {
--
2.37.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t
2022-09-17 9:59 [FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t remi
@ 2022-09-17 10:46 ` Andreas Rheinhardt
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Rheinhardt @ 2022-09-17 10:46 UTC (permalink / raw)
To: ffmpeg-devel
remi@remlab.net:
> From: Rémi Denis-Courmont <remi@remlab.net>
>
> While this probably never overflows, we are better safe than sorry.
>
> The callback prototype should probably also use ptrdiff_t or size_t but
> I diggress.
> ---
> libavcodec/vorbisdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vorbisdec.c b/libavcodec/vorbisdec.c
> index 38a5367be3..9728997370 100644
> --- a/libavcodec/vorbisdec.c
> +++ b/libavcodec/vorbisdec.c
> @@ -1581,7 +1581,7 @@ static inline int vorbis_residue_decode(vorbis_context *vc, vorbis_residue *vr,
>
> void ff_vorbis_inverse_coupling(float *mag, float *ang, intptr_t blocksize)
> {
> - int i;
> + ptrdiff_t i;
> for (i = 0; i < blocksize; i++) {
> if (mag[i] > 0.0) {
> if (ang[i] > 0.0) {
We allow the C99 "for (ptrdiff_t i = 0;".
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-17 10:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17 9:59 [FFmpeg-devel] [PATCH 1/2] lavc/vorbisdec: use ptrdiff_t to iterate over intptr_t remi
2022-09-17 10:46 ` Andreas Rheinhardt
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git