From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 86942435C2 for ; Fri, 16 Sep 2022 17:27:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8982F68BACD; Fri, 16 Sep 2022 20:27:04 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7098968BA38 for ; Fri, 16 Sep 2022 20:26:58 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 7FE241BF209 for ; Fri, 16 Sep 2022 17:26:56 +0000 (UTC) Date: Fri, 16 Sep 2022 19:26:55 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220916172655.GV2088045@pb2> References: <20220907200233.21255-1-pal@sandflow.com> MIME-Version: 1.0 In-Reply-To: <20220907200233.21255-1-pal@sandflow.com> Subject: Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6751888581899200904==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6751888581899200904== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b4OUYJu3fgafNw5n" Content-Disposition: inline --b4OUYJu3fgafNw5n Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 07, 2022 at 01:02:33PM -0700, pal@sandflow.com wrote: > From: Pierre-Anthony Lemieux >=20 > Addresses coverity 1512414 >=20 > --- > libavformat/imfdec.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) >=20 > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index 5bbe7a53f8..58b1455c9f 100644 > --- a/libavformat/imfdec.c > +++ b/libavformat/imfdec.c > @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_wi= th_minimum_timestamp(AVForma > { > IMFContext *c =3D s->priv_data; > IMFVirtualTrackPlaybackCtx *track; > + AVRational minimum_timestamp =3D av_make_q(INT_MAX, 1); > - AVRational minimum_timestamp =3D av_make_q(INT32_MAX, 1); iam not sure thats a good idea, it would change behavior on different platf= orms thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle --b4OUYJu3fgafNw5n Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYySx1AAKCRBhHseHBAsP q1/9AJsFzq4VTRoztKce6L347IhdKwKwAgCeJCupmjIS4Y9yufU7Lf8S6q6JCm8= =Aedc -----END PGP SIGNATURE----- --b4OUYJu3fgafNw5n-- --===============6751888581899200904== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6751888581899200904==--