Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback
Date: Fri, 16 Sep 2022 19:26:55 +0200
Message-ID: <20220916172655.GV2088045@pb2> (raw)
In-Reply-To: <20220907200233.21255-1-pal@sandflow.com>

[-- Attachment #1.1: Type: text/plain, Size: 1046 bytes --]

On Wed, Sep 07, 2022 at 01:02:33PM -0700, pal@sandflow.com wrote:
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
> 
> Addresses coverity 1512414
> 
> ---
>  libavformat/imfdec.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
> index 5bbe7a53f8..58b1455c9f 100644
> --- a/libavformat/imfdec.c
> +++ b/libavformat/imfdec.c
> @@ -681,8 +681,11 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma
>  {
>      IMFContext *c = s->priv_data;
>      IMFVirtualTrackPlaybackCtx *track;

> +    AVRational minimum_timestamp = av_make_q(INT_MAX, 1);
> -    AVRational minimum_timestamp = av_make_q(INT32_MAX, 1);

iam not sure thats a good idea, it would change behavior on different platforms

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".