From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DDCA743E59 for ; Thu, 15 Sep 2022 18:00:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3DD6568BBDA; Thu, 15 Sep 2022 21:00:15 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2263B68BBD5 for ; Thu, 15 Sep 2022 21:00:09 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 64B56240006 for ; Thu, 15 Sep 2022 18:00:08 +0000 (UTC) Date: Thu, 15 Sep 2022 20:00:07 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220915180007.GR2088045@pb2> References: <20220910192330.30872-1-philipl@overt.org> <20220914210816.GP2088045@pb2> <20220914154304.64a99103@fido7> MIME-Version: 1.0 In-Reply-To: <20220914154304.64a99103@fido7> Subject: Re: [FFmpeg-devel] [PATCH] v2: lavu/pixdesc: favour formats where depth and subsampling exactly match X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3076639785511751198==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3076639785511751198== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Cd004DbFpHlNXMQI" Content-Disposition: inline --Cd004DbFpHlNXMQI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 14, 2022 at 03:43:04PM -0700, Philip Langdale wrote: > On Wed, 14 Sep 2022 23:08:16 +0200 > Michael Niedermayer wrote: [...] > > > + // Favour formats where bit depth exactly matches. If > > > all other > > > + // scoring is equal, we'd rather use the bit depth > > > that most closely > > > + // matches the source. =20 > >=20 > > ok > >=20 > >=20 > > > + loss |=3D FF_LOSS_EXCESS_DEPTH; > > > + score -=3D 1 << -depth_delta; =20 > >=20 > > but does that do that ? > > a 1bpp -> 16bpp has a considerable -depth_delta > >=20 > > do we need the << at all ? >=20 > The idea here is to have the scoring reflect the gap. Are you saying > you'd just apply the depth_delta as-is (just a small number 1 <=3D n <=3D > 15)? yes it makes this less constrained with the shifts there are only 32 distinct values with a int I presume the shifts where there to give the loss some material sense as in PSNR or SAD or something like that, 8 bits output having 4 times worse precission than 10 bit for example.=20 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. --Cd004DbFpHlNXMQI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYyNoIwAKCRBhHseHBAsP q7PsAJ9+JGfgH/RK0AAIw2LkfkTSPO7T7QCfRxtFu+dIVCDxvUClaR0KfOduOr4= =cuyp -----END PGP SIGNATURE----- --Cd004DbFpHlNXMQI-- --===============3076639785511751198== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3076639785511751198==--