From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CC12F4441F for ; Fri, 9 Sep 2022 14:56:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E89768BB0B; Fri, 9 Sep 2022 17:56:07 +0300 (EEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4850868BAD1 for ; Fri, 9 Sep 2022 17:56:00 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 092ACC000A for ; Fri, 9 Sep 2022 14:55:58 +0000 (UTC) Date: Fri, 9 Sep 2022 16:55:58 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220909145558.GE2088045@pb2> References: <20220908173911.GA2088045@pb2> <20220908202528.GB2088045@pb2> MIME-Version: 1.0 In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/2] swscale/input: Avoid calls to av_pix_fmt_desc_get() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0634397360280800306==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0634397360280800306== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="307FGJNKNK2k8fNP" Content-Disposition: inline --307FGJNKNK2k8fNP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 08, 2022 at 11:44:51PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Sep 08, 2022 at 09:38:51PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: [...] > > To me if i look at the evolution > > of isBE() / code checking BE-ness it become more messy over time > >=20 > > I think it would be interresting to think about if we can make > > av_pix_fmt_desc_get(compile time constant) work at compile time. > > or if we maybe can return to a simpler implementation > >=20 >=20 > We could put the av_pix_fmt_descriptors array into an internal header > and use something like >=20 > static av_always_inline const AVPixFmtDescriptor > *ff_pix_fmt_descriptor_get(enum AVPixelFormat fmt) > { > if (av_builtin_constant_p(fmt)) > return &av_pix_fmt_descriptors[fmt]; > return av_pix_fmt_desc_get(fmt); > } yes thats what i was thinking of too. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I do not agree with what you have to say, but I'll defend to the death your right to say it. -- Voltaire --307FGJNKNK2k8fNP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYxtT+QAKCRBhHseHBAsP qyUtAKCY7zF+VbyBZKzKos/7XwmVmsCQuACgidtV4mBYbSLHb3QGZ2oHkiHNt4I= =e6S6 -----END PGP SIGNATURE----- --307FGJNKNK2k8fNP-- --===============0634397360280800306== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0634397360280800306==--