From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E212E443C3 for ; Thu, 8 Sep 2022 16:31:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E227168BAC8; Thu, 8 Sep 2022 19:31:26 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 18B7C68B7A0 for ; Thu, 8 Sep 2022 19:31:21 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 63724240011 for ; Thu, 8 Sep 2022 16:31:20 +0000 (UTC) Date: Thu, 8 Sep 2022 18:31:19 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220908163119.GY2088045@pb2> References: <20220417172658.GN3529341@pb2> <20220906214704.704687-1-izadi@google.com> <0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com> MIME-Version: 1.0 In-Reply-To: <0c396bde-b983-9722-2aa0-bf5c4eec77c3@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avformat/matroska: Support HDR10+ metadata in Matroska. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6019414703483083195==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6019414703483083195== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Z5G2R6hIjkQ11lIG" Content-Disposition: inline --Z5G2R6hIjkQ11lIG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 07, 2022 at 02:12:46PM +0100, Derek Buitenhuis wrote: > On 9/6/2022 10:47 PM, Mohammad Izadi wrote: > > + if (side_data && side_data_size > 0) > > + ff_write_dynamic_hdr10_plus_to_full_itu_t_t35((AVDynamicHDRPlu= s*)side_data, &hdr10_plus_itu_t_t35, &hdr10_plus_itu_t_t35_size); >=20 > You can't use ff_-prefixed functions across library boundaries. >=20 > It nees to be either public (av*) or avpriv. I suspect people won't want = it to > be avpriv. >=20 > Personally, I think having serialization as a public API is useful, but Y= MMV. Mostly > because I was just writing my own serialization to make use of the export= ed side data :P. I agree on a related subject, side data serialization should be moved to a common A= PI We have common APIs for parsers, decoder, bitstream filters but for=20 parsing/decoding side data this is heading toward something less structured Above is not a comment on this patch, the patch is fine. I just want to poi= nt to this before we have several dozen such functions which need to be deprecated and supported when a more structured system is introduced thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad --Z5G2R6hIjkQ11lIG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iFwEABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYxoY1AAKCRBhHseHBAsP q3tQAJjQZ4N9U8kZuiDq7qKhhFlWO65bAJ45R1JyDJqCOoLp83caOc3otd7pXw== =yZJG -----END PGP SIGNATURE----- --Z5G2R6hIjkQ11lIG-- --===============6019414703483083195== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6019414703483083195==--