From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A11D6443B8 for ; Thu, 8 Sep 2022 03:44:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B29368B99B; Thu, 8 Sep 2022 06:44:39 +0300 (EEST) Received: from mail.overt.org (mail.overt.org [157.230.92.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D48768B959 for ; Thu, 8 Sep 2022 06:44:33 +0300 (EEST) Received: from authenticated-user (mail.overt.org [157.230.92.47]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.overt.org (Postfix) with ESMTPSA id 191693F41C for ; Wed, 7 Sep 2022 22:44:29 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=overt.org; s=mail; t=1662608670; bh=dTuIMOYe+QQjvEOb2LJHQu668kOJOrpZaIvxpXE/rzs=; h=Date:From:To:Subject:In-Reply-To:References:From; b=QbaNOm1y3ddT07v0BRp94RFFy2EzhYNtn20w4nTaJ2cDW46QwUTbtJwp6/eS/8FTC +xMd1QWGCniCB45g+xc9W8mMylF3Ux/K5MS4X52dcz3cVWL8DpWj0GE7Y47gOqGEC/ tajF2TkxsFNlJdmDzRpqRg34MKA14JFZR4CAhBngt6n/md5Yix077SCVovxSnPiwG8 Mnp58JWoG0OrN6+UGBzTD813CfJHdTAtSKT+vq90GshkAacI8xldPh5oeUNY6C0zNg Ge45LZbB743vA3rv/HAPKberSFcDm2VU3cz9x7w+pGxC6NiJc3LCI7wIBJoc0tYK/v DA4DdpKg46rBA== Date: Wed, 7 Sep 2022 20:44:26 -0700 From: Philip Langdale To: ffmpeg-devel@ffmpeg.org Message-ID: <20220907204426.71a40a06@fido7> In-Reply-To: References: MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] swscale/input: Remove spec-incompliant '; ' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 8 Sep 2022 04:31:55 +0200 Andreas Rheinhardt wrote: > These macros are definitions, not only declarations and therefore > should not contain a semicolon. Such a semicolon is actually > spec-incompliant, but compilers happen to accept them. > > Signed-off-by: Andreas Rheinhardt > --- > libswscale/input.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libswscale/input.c b/libswscale/input.c > index be8f3940e1..88e318e664 100644 > --- a/libswscale/input.c > +++ b/libswscale/input.c > @@ -583,8 +583,8 @@ static void yvy2ToUV_c(uint8_t *dstU, uint8_t > *dstV, const uint8_t *unused0, con AV_WN16(dst + i * 2, AV_RL16(src + > i * 4) >> shift); \ } > > -y21xle_wrapper(10, 6); > -y21xle_wrapper(12, 4); > +y21xle_wrapper(10, 6) > +y21xle_wrapper(12, 4) > > static void bswap16Y_c(uint8_t *_dst, const uint8_t *_src, const > uint8_t *unused1, const uint8_t *unused2, int width, uint32_t > *unused, void *opq) @@ -828,9 +828,9 @@ static void > nv21ToUV_c(uint8_t *dstU, uint8_t *dstV, } > \ p01x_uv_wrapper(bits, shift) > > -p01x_wrapper(10, 6); > -p01x_wrapper(12, 4); > -p01x_uv_wrapper(16, 0); > +p01x_wrapper(10, 6) > +p01x_wrapper(12, 4) > +p01x_uv_wrapper(16, 0) > > #define input_pixel(pos) (isBE(origin) ? AV_RB16(pos) : AV_RL16(pos)) > Thanks for catching this. LGTM. --phil _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".