From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 3C0C5442FC
	for <ffmpegdev@gitmailbox.com>; Mon,  5 Sep 2022 18:09:56 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 401A768B980;
	Mon,  5 Sep 2022 21:09:54 +0300 (EEST)
Received: from mail.overt.org (mail.overt.org [157.230.92.47])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7284568B320
 for <ffmpeg-devel@ffmpeg.org>; Mon,  5 Sep 2022 21:09:47 +0300 (EEST)
Received: from authenticated-user (mail.overt.org [157.230.92.47])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.overt.org (Postfix) with ESMTPSA id 081023F35B
 for <ffmpeg-devel@ffmpeg.org>; Mon,  5 Sep 2022 13:09:45 -0500 (CDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=overt.org; s=mail;
 t=1662401386; bh=yZRAE/Ck3MkjuICLuNo3/Mz5ePl2iUXu09t9dLOZJZU=;
 h=Date:From:To:Subject:In-Reply-To:References:From;
 b=mmWHnM8Tu5PlfLye1SYok9sxtaKcp36gmCv3+cdKQfHzJjbzwKe0qWbXlo1HaSV6Y
 Ruv2hKoxtLlM97K9Vzh4OAgVK8f5ohvpGtIvpalrhC5Qq+3/uVvk8PazWRRGSnP/cR
 y+yoCmoxSF8oD5TQl5IA3isbCT04KIQ8WlpkPg2P8RNHMoi9wXB7E23GKaqiuZGW3b
 Fy4Ty7b5VsvVi1GnZ94owZL4NwSmtztwYggUveOWoblZ88jK2VbpHdfaiuincAEShc
 ZOlFJEeyK440YAU83a7y1I7l8m4hZyEG2zEhjh/QVUO6N9FsZ94J/sxU6pVsP9fU16
 j+0hVUxqEWiZg==
Date: Mon, 5 Sep 2022 11:09:41 -0700
From: Philip Langdale <philipl@overt.org>
To: ffmpeg-devel@ffmpeg.org
Message-ID: <20220905110941.50b4d333@fido7>
In-Reply-To: <e5e4051e-7d6e-c207-a34f-0dbbd5845568@gmail.com>
References: <20220826021736.355903-1-philipl@overt.org>
 <20220826021736.355903-2-philipl@overt.org>
 <e5e4051e-7d6e-c207-a34f-0dbbd5845568@gmail.com>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavu/pixfmt: Add P012, Y212, XV30,
 and XV36 formats
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/20220905110941.50b4d333@fido7/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 5 Sep 2022 11:51:56 -0300
James Almer <jamrial@gmail.com> wrote:

> On 8/25/2022 11:17 PM, Philip Langdale wrote:
> >   static const char * const color_range_names[] = {
> > @@ -2778,7 +2871,7 @@ void ff_check_pixfmt_descriptors(void){
> >   
> >           if (!d->name && !d->nb_components && !d->log2_chroma_w &&
> > !d->log2_chroma_h && !d->flags) continue;
> > -//         av_log(NULL, AV_LOG_DEBUG, "Checking: %s\n", d->name);
> > +        av_log(NULL, AV_LOG_INFO, "Checking: %s\n", d->name);
> >           av_assert0(d->log2_chroma_w <= 3);
> >           av_assert0(d->log2_chroma_h <= 3);
> >           av_assert0(d->nb_components <= 4);  
> 
> Unintended change?

Actually intended. Because if there is a problem and the assert fails,
you can't tell what format was being tested. It seems you want it on
all the time, otherwise the test isn't helpful out-of-the-box.

--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".