From: Philip Langdale <philipl@overt.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavu/pixfmt: Add P012, Y212, XV30, and XV36 formats
Date: Mon, 5 Sep 2022 11:09:41 -0700
Message-ID: <20220905110941.50b4d333@fido7> (raw)
In-Reply-To: <e5e4051e-7d6e-c207-a34f-0dbbd5845568@gmail.com>
On Mon, 5 Sep 2022 11:51:56 -0300
James Almer <jamrial@gmail.com> wrote:
> On 8/25/2022 11:17 PM, Philip Langdale wrote:
> > static const char * const color_range_names[] = {
> > @@ -2778,7 +2871,7 @@ void ff_check_pixfmt_descriptors(void){
> >
> > if (!d->name && !d->nb_components && !d->log2_chroma_w &&
> > !d->log2_chroma_h && !d->flags) continue;
> > -// av_log(NULL, AV_LOG_DEBUG, "Checking: %s\n", d->name);
> > + av_log(NULL, AV_LOG_INFO, "Checking: %s\n", d->name);
> > av_assert0(d->log2_chroma_w <= 3);
> > av_assert0(d->log2_chroma_h <= 3);
> > av_assert0(d->nb_components <= 4);
>
> Unintended change?
Actually intended. Because if there is a problem and the assert fails,
you can't tell what format was being tested. It seems you want it on
all the time, otherwise the test isn't helpful out-of-the-box.
--phil
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-09-05 18:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 2:17 [FFmpeg-devel] [PATCH 0/3] V5: VAAPI: Add high bit depth encode/decode support Philip Langdale
2022-08-26 2:17 ` [FFmpeg-devel] [PATCH 1/3] lavu/pixfmt: Add P012, Y212, XV30, and XV36 formats Philip Langdale
2022-09-05 14:51 ` James Almer
2022-09-05 18:09 ` Philip Langdale [this message]
2022-08-26 2:17 ` [FFmpeg-devel] [PATCH 2/3] lavc/vaapi: Add support for remaining 10/12bit profiles Philip Langdale
2022-08-26 2:17 ` [FFmpeg-devel] [PATCH 3/3] lavu/hwcontext_vulkan: support mapping VUYX, P012, and XV36 Philip Langdale
2022-09-01 16:37 ` [FFmpeg-devel] [PATCH 0/3] V5: VAAPI: Add high bit depth encode/decode support Philip Langdale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220905110941.50b4d333@fido7 \
--to=philipl@overt.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git