From: real.zhurui@gmail.com
To: ffmpeg-devel@ffmpeg.org
Cc: Rui Zhu <real.zhurui@gmail.com>
Subject: [FFmpeg-devel] [PATCH v1] avfilter/af_loudnorm: fix incorrect gain when audio is shorter than 3s
Date: Wed, 31 Aug 2022 20:51:06 +0800
Message-ID: <20220831125106.21978-1-real.zhurui@gmail.com> (raw)
From: Rui Zhu <real.zhurui@gmail.com>
The input data is multiplied by `s->offset` to get normalized output.
`s->target_tp` and `true_peak` is not in dB,
so `s->offset` should be calculated by division instead of subtraction.
Signed-off-by: Rui Zhu <real.zhurui@gmail.com>
---
libavfilter/af_loudnorm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/af_loudnorm.c b/libavfilter/af_loudnorm.c
index 8d2379f14e..ce61e985b1 100644
--- a/libavfilter/af_loudnorm.c
+++ b/libavfilter/af_loudnorm.c
@@ -455,7 +455,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
offset = pow(10., (s->target_i - global) / 20.);
offset_tp = true_peak * offset;
- s->offset = offset_tp < s->target_tp ? offset : s->target_tp - true_peak;
+ s->offset = offset_tp < s->target_tp ? offset : s->target_tp / true_peak;
s->frame_type = LINEAR_MODE;
}
--
2.32.1 (Apple Git-133)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2022-08-31 12:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831125106.21978-1-real.zhurui@gmail.com \
--to=real.zhurui@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git