From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4C14F421F1 for ; Mon, 29 Aug 2022 21:54:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 214F768BAC6; Tue, 30 Aug 2022 00:54:30 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 079AF68BA02 for ; Tue, 30 Aug 2022 00:54:23 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 4CC2A240002 for ; Mon, 29 Aug 2022 21:54:23 +0000 (UTC) Date: Mon, 29 Aug 2022 23:54:22 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220829215422.GK2088045@pb2> References: <20220829144320.330685-1-bpeeluk.ref@yahoo.co.uk> <20220829144320.330685-1-bpeeluk@yahoo.co.uk> MIME-Version: 1.0 In-Reply-To: <20220829144320.330685-1-bpeeluk@yahoo.co.uk> Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/file: Add a specialized url_check callback for pipe protocol X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4857891081606605115==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4857891081606605115== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lOUljPM2ThZHjS+s" Content-Disposition: inline --lOUljPM2ThZHjS+s Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 29, 2022 at 04:43:19PM +0200, Neil Roberts wrote: > Using file_check for the pipe protocol doesn't make sense. For example, > for a URL like =E2=80=9Cpipe:0=E2=80=9D it would end up checking whether = the =E2=80=9Cpipe:0=E2=80=9D > file exists. This patch instead makes it check the access modes on the > corresponding file descriptor using fcntl. >=20 > Signed-off-by: Neil Roberts > --- > libavformat/file.c | 40 +++++++++++++++++++++++++++++++++++++--- > 1 file changed, 37 insertions(+), 3 deletions(-) breaks on mingw64 src/libavformat/file.c: In function =E2=80=98pipe_check=E2=80=99: src/libavformat/file.c:411:24: error: implicit declaration of function =E2= =80=98fcntl=E2=80=99; did you mean =E2=80=98rintl=E2=80=99? [-Werror=3Dimpl= icit-function-declaration] int status_flags =3D fcntl(fd, F_GETFL); ^~~~~ rintl src/libavformat/file.c:411:34: error: =E2=80=98F_GETFL=E2=80=99 undeclared = (first use in this function) int status_flags =3D fcntl(fd, F_GETFL); ^~~~~~~ src/libavformat/file.c:411:34: note: each undeclared identifier is reported= only once for each function it appears in cc1: some warnings being treated as errors [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct answe= r. --lOUljPM2ThZHjS+s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYw01hQAKCRBhHseHBAsP q4ceAJ9wh4gRzOEjhqFJi4mbDdDeA7bz7wCdG9s1lsrFcRqnuxjUieXYbU6l65Y= =mbOZ -----END PGP SIGNATURE----- --lOUljPM2ThZHjS+s-- --===============4857891081606605115== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4857891081606605115==--