From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: don't read duration from mvhd atom
Date: Sun, 28 Aug 2022 00:33:56 +0200
Message-ID: <20220827223356.GX2088045@pb2> (raw)
In-Reply-To: <b17fa079-fe3f-10d1-a597-a85e48437016@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1545 bytes --]
On Sat, Aug 27, 2022 at 04:41:39PM -0300, James Almer wrote:
> On 8/16/2022 4:22 PM, Michael Niedermayer wrote:
> > On Mon, Aug 15, 2022 at 08:14:42PM -0300, James Almer wrote:
> > > This duration is equal to the longest duration in all track's tkhd atoms, which
> > > may be comprised of the sum of all edit lists in each track. Empty edit lists
> > > in tracks represent start_time, and the actual media duration is stored in the
> > > mdhd atom.
> > > This change lets the generic demux code derive the longest track duration taken
> > > from mdhd atoms, so the correct duration and start_time combination will be
> > > reported.
> > >
> > > Should fix ticket #9775.
> > >
> > > Signed-off-by: James Almer <jamrial@gmail.com>
> > > ---
> > > libavformat/mov.c | 4 ----
> > > tests/ref/fate/gaplessenc-itunes-to-ipod-aac | 2 +-
> > > 2 files changed, 1 insertion(+), 5 deletions(-)
> >
> > No idea if its a bad or good change but this changes the output for:
> > ./ffmpeg -f concat -i ~/tickets/3108/concatfile.txt -codec copy -bitexact /tmp/3108.avi
> >
> > thx
>
> I don't see an avi file in that ticket, but for the mov in the zip file, the
> video track duration is used after this patch.
the avi is generated in that command from the concatfile.txt from the tickets zip
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-27 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 23:14 James Almer
2022-08-16 7:18 ` "zhilizhao(赵志立)"
2022-08-16 19:22 ` Michael Niedermayer
2022-08-27 19:41 ` James Almer
2022-08-27 22:33 ` Michael Niedermayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827223356.GX2088045@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git