From: Steven Liu <lq@chinaffmpeg.org> To: ffmpeg-devel@ffmpeg.org Cc: Steven Liu <lq@chinaffmpeg.org> Subject: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it Date: Fri, 26 Aug 2022 14:44:56 +0800 Message-ID: <20220826064456.92895-1-lq@chinaffmpeg.org> (raw) In-Reply-To: <CAF_7JxBag2=-9gT2UKSMxuZCJ_kwtSh96kFnqBKZjG1M9FyeUA@mail.gmail.com> fix CID: 1512414 And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp incorrect in imf_read_packet; Signed-off-by: Steven Liu <lq@chinaffmpeg.org> --- libavformat/imfdec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c index 5bbe7a53f8..08f342bc1a 100644 --- a/libavformat/imfdec.c +++ b/libavformat/imfdec.c @@ -697,8 +697,9 @@ static IMFVirtualTrackPlaybackCtx *get_next_track_with_minimum_timestamp(AVForma } } - av_log(s, AV_LOG_DEBUG, "Found next track to read: %d (timestamp: %lf / %lf)\n", - track->index, av_q2d(track->current_timestamp), av_q2d(minimum_timestamp)); + if (track) + av_log(s, AV_LOG_DEBUG, "Found next track to read: %d (timestamp: %lf / %lf)\n", + track->index, av_q2d(track->current_timestamp), av_q2d(minimum_timestamp)); return track; } @@ -760,6 +761,8 @@ static int imf_read_packet(AVFormatContext *s, AVPacket *pkt) AVRational next_timestamp; track = get_next_track_with_minimum_timestamp(s); + if (!track) + return AVERROR_INVALIDDATA; ret = get_resource_context_for_timestamp(s, track, &resource); if (ret) -- 2.25.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-26 6:45 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-26 2:50 [FFmpeg-devel] [PATCH 1/2] " Steven Liu 2022-08-26 2:50 ` [FFmpeg-devel] [PATCH 2/2] avformat/dashdec: check val before xmlFree it Steven Liu 2022-08-26 3:52 ` [FFmpeg-devel] [PATCH 1/2] avformat/imfdec: check track valid before use it Pierre-Anthony Lemieux 2022-08-26 6:12 ` Steven Liu 2022-08-26 6:44 ` Steven Liu [this message] 2022-08-26 8:37 ` [FFmpeg-devel] [PATCH v2] " Andreas Rheinhardt 2022-08-26 15:44 ` Pierre-Anthony Lemieux 2022-08-26 16:01 ` Andreas Rheinhardt 2022-08-26 16:06 ` Pierre-Anthony Lemieux 2022-08-27 12:25 ` Steven Liu 2022-08-27 17:25 ` Pierre-Anthony Lemieux 2022-09-08 15:21 ` Pierre-Anthony Lemieux
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220826064456.92895-1-lq@chinaffmpeg.org \ --to=lq@chinaffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git