From: Steven Liu <lq@chinaffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Steven Liu <lq@chinaffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/2] avformat/dashdec: check val before xmlFree it
Date: Fri, 26 Aug 2022 10:50:16 +0800
Message-ID: <20220826025016.29627-2-lq@chinaffmpeg.org> (raw)
In-Reply-To: <20220826025016.29627-1-lq@chinaffmpeg.org>
fix CID: 1512404
When there have no val value should not xmlFree it.
Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
libavformat/dashdec.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 63bf7e96a5..bf9adf2183 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -1185,8 +1185,10 @@ static int parse_programinformation(AVFormatContext *s, xmlNodePtr node)
}
}
node = xmlNextElementSibling(node);
- xmlFree(val);
- val = NULL;
+ if (val) {
+ xmlFree(val);
+ val = NULL;
+ }
}
return 0;
}
--
2.25.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-26 2:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 2:50 [FFmpeg-devel] [PATCH 1/2] avformat/imfdec: check track valid before use it Steven Liu
2022-08-26 2:50 ` Steven Liu [this message]
2022-08-26 3:52 ` Pierre-Anthony Lemieux
2022-08-26 6:12 ` Steven Liu
2022-08-26 6:44 ` [FFmpeg-devel] [PATCH v2] " Steven Liu
2022-08-26 8:37 ` Andreas Rheinhardt
2022-08-26 15:44 ` Pierre-Anthony Lemieux
2022-08-26 16:01 ` Andreas Rheinhardt
2022-08-26 16:06 ` Pierre-Anthony Lemieux
2022-08-27 12:25 ` Steven Liu
2022-08-27 17:25 ` Pierre-Anthony Lemieux
2022-09-08 15:21 ` Pierre-Anthony Lemieux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826025016.29627-2-lq@chinaffmpeg.org \
--to=lq@chinaffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git