From: rcombs <rcombs@rcombs.me>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH 2/3] lavf/metadata: support duplicate keys in ff_metadata_conv
Date: Wed, 24 Aug 2022 19:27:21 -0500
Message-ID: <20220825002722.79902-2-rcombs@rcombs.me> (raw)
In-Reply-To: <20220825002722.79902-1-rcombs@rcombs.me>
---
libavformat/metadata.c | 2 +-
tests/ref/fate/cover-art-aiff-id3v2-remux | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/metadata.c b/libavformat/metadata.c
index b9b6de7972..2a1ffc69e7 100644
--- a/libavformat/metadata.c
+++ b/libavformat/metadata.c
@@ -50,7 +50,7 @@ void ff_metadata_conv(AVDictionary **pm, const AVMetadataConv *d_conv,
key = dc->native;
break;
}
- av_dict_set(&dst, key, mtag->value, 0);
+ av_dict_set(&dst, key, mtag->value, AV_DICT_MULTIKEY | AV_DICT_DEDUP);
}
av_dict_free(pm);
*pm = dst;
diff --git a/tests/ref/fate/cover-art-aiff-id3v2-remux b/tests/ref/fate/cover-art-aiff-id3v2-remux
index 3ca2855eb8..2eac5f8d9c 100644
--- a/tests/ref/fate/cover-art-aiff-id3v2-remux
+++ b/tests/ref/fate/cover-art-aiff-id3v2-remux
@@ -67,10 +67,10 @@ TAG:title=third
TAG:comment=Conductor
[/STREAM]
[FORMAT]
-TAG:artist=Мельница
+TAG:title=Дороги
TAG:RATING=0
TAG:album=Ангелофрения
-TAG:title=Дороги
+TAG:artist=Мельница
TAG:tracktotal=11
TAG:totaltracks=11
TAG:genre=Folk
--
2.37.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-25 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 0:27 [FFmpeg-devel] [PATCH 1/3] lavu/dict: add AV_DICT_DEDUP rcombs
2022-08-25 0:27 ` rcombs [this message]
2022-08-25 0:27 ` [FFmpeg-devel] [PATCH 3/3] lavf/id3v2dec: support multiple values and TIPL frames rcombs
2025-04-06 18:49 ` [FFmpeg-devel] [PATCH 1/3] lavu/dict: add AV_DICT_DEDUP Michael Niedermayer
-- strict thread matches above, loose matches on Subject: below --
2022-08-24 23:51 rcombs
2022-08-24 23:51 ` [FFmpeg-devel] [PATCH 2/3] lavf/metadata: support duplicate keys in ff_metadata_conv rcombs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825002722.79902-2-rcombs@rcombs.me \
--to=rcombs@rcombs.me \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git