From: Anton Khirnov <anton@khirnov.net> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 07/18] lavc/dv: do not pass DVVideoContext to dv_calculate_mb_xy() Date: Wed, 24 Aug 2022 10:43:07 +0200 Message-ID: <20220824084318.333-7-anton@khirnov.net> (raw) In-Reply-To: <20220824084318.333-1-anton@khirnov.net> Pass the two variables needed from it directly. This is done in preparation to splitting DVVideoContext. --- libavcodec/dv.h | 5 +++-- libavcodec/dvdec.c | 2 +- libavcodec/dvenc.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/dv.h b/libavcodec/dv.h index 286b267de2..6430688795 100644 --- a/libavcodec/dv.h +++ b/libavcodec/dv.h @@ -107,7 +107,8 @@ static inline int dv_work_pool_size(const AVDVProfile *d) return size; } -static inline void dv_calculate_mb_xy(const DVVideoContext *s, +static inline void dv_calculate_mb_xy(const AVDVProfile *sys, + const uint8_t *buf, const DVwork_chunk *work_chunk, int m, int *mb_x, int *mb_y) { @@ -116,7 +117,7 @@ static inline void dv_calculate_mb_xy(const DVVideoContext *s, /* We work with 720p frames split in half. * The odd half-frame (chan == 2,3) is displaced :-( */ - if (s->sys->height == 720 && !(s->buf[1] & 0x0C)) + if (sys->height == 720 && !(buf[1] & 0x0C)) /* shifting the Y coordinate down by 72/2 macro blocks */ *mb_y -= (*mb_y > 17) ? 18 : -72; } diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c index 1e2c097ed0..7f9e4eb0c0 100644 --- a/libavcodec/dvdec.c +++ b/libavcodec/dvdec.c @@ -535,7 +535,7 @@ retry: block = &sblock[0][0]; mb = mb_data; for (mb_index = 0; mb_index < 5; mb_index++) { - dv_calculate_mb_xy(s, work_chunk, mb_index, &mb_x, &mb_y); + dv_calculate_mb_xy(s->sys, s->buf, work_chunk, mb_index, &mb_x, &mb_y); /* idct_put'ting luminance */ if ((s->sys->pix_fmt == AV_PIX_FMT_YUV420P) || diff --git a/libavcodec/dvenc.c b/libavcodec/dvenc.c index 712ca325de..c12fce9e8b 100644 --- a/libavcodec/dvenc.c +++ b/libavcodec/dvenc.c @@ -866,7 +866,7 @@ static int dv_encode_video_segment(AVCodecContext *avctx, void *arg) p = dif = &s->buf[work_chunk->buf_offset * 80]; enc_blk = &enc_blks[0]; for (mb_index = 0; mb_index < 5; mb_index++) { - dv_calculate_mb_xy(s, work_chunk, mb_index, &mb_x, &mb_y); + dv_calculate_mb_xy(s->sys, s->buf, work_chunk, mb_index, &mb_x, &mb_y); qnos[mb_index] = DV_PROFILE_IS_HD(s->sys) ? 1 : 15; -- 2.35.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-08-24 8:45 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-24 8:43 [FFmpeg-devel] [PATCH 01/18] tests/fate/mov: add a test for dv audio demuxed through dv demuxer Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 02/18] lavf/dv: remove DVMuxContext declaration from dv.h Anton Khirnov 2022-08-24 11:55 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 03/18] lavf/dv: always provide avpriv_dv_* symbols Anton Khirnov 2022-08-24 16:25 ` Andreas Rheinhardt 2022-08-25 9:47 ` Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 04/18] lavc/dvdec: drop the only use of DVVideoContext.avctx Anton Khirnov 2022-08-24 12:24 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 05/18] lavc/dv: remove ff_dvvideo_init() Anton Khirnov 2022-08-24 12:27 ` Andreas Rheinhardt 2022-08-25 10:10 ` [FFmpeg-devel] [PATCH] " Anton Khirnov 2022-08-25 9:48 ` [FFmpeg-devel] [PATCH 05/18] " Anton Khirnov 2022-08-25 9:55 ` Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 06/18] lavc/dv: do not pass DVVideoContext to ff_dv_init_dynamic_tables() Anton Khirnov 2022-08-24 12:28 ` Andreas Rheinhardt 2022-08-24 8:43 ` Anton Khirnov [this message] 2022-08-24 12:57 ` [FFmpeg-devel] [PATCH 07/18] lavc/dv: do not pass DVVideoContext to dv_calculate_mb_xy() Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 08/18] lavc/dvdec: stop using DVVideoContext Anton Khirnov 2022-08-24 12:33 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 09/18] lavc/dvenc: " Anton Khirnov 2022-08-24 12:36 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 10/18] lavc/dv.h: move encoder/decoder-specific code to a new header Anton Khirnov 2022-08-24 12:52 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 11/18] lavc/dv: rename constants to follow our naming conventions Anton Khirnov 2022-08-24 12:38 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 12/18] lavf/dv: make returning the video packet optional Anton Khirnov 2022-08-24 16:03 ` Andreas Rheinhardt 2022-08-31 2:39 ` Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 13/18] lavf/dv: return a meaningful error code from avpriv_dv_produce_packet() Anton Khirnov 2022-08-24 13:07 ` Andreas Rheinhardt 2022-08-31 2:48 ` [FFmpeg-devel] [PATCH] " Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 14/18] lavf/dv: forward errors from avformat_new_stream() Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 15/18] lavf/dv: set non-changing AVStream fields only once Anton Khirnov 2022-08-24 13:13 ` Andreas Rheinhardt 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 16/18] lavf/dv: set audio bitrate only at stream creation Anton Khirnov 2022-08-24 13:13 ` Andreas Rheinhardt 2022-08-24 14:33 ` Andreas Rheinhardt 2022-08-25 10:23 ` Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 17/18] lavf/dv: do not update AVCodecParameters.sample_rate while demuxing Anton Khirnov 2022-08-24 14:20 ` Andreas Rheinhardt 2022-08-31 3:11 ` Anton Khirnov 2022-08-24 8:43 ` [FFmpeg-devel] [PATCH 18/18] lavf/dv: do not continuously set stream timebase Anton Khirnov 2022-08-24 14:42 ` Andreas Rheinhardt 2022-08-25 19:04 ` Marton Balint 2022-08-24 8:50 ` [FFmpeg-devel] [PATCH 01/18] tests/fate/mov: add a test for dv audio demuxed through dv demuxer Anton Khirnov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220824084318.333-7-anton@khirnov.net \ --to=anton@khirnov.net \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git