From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 03BD143FA4 for ; Tue, 23 Aug 2022 17:53:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF59A68B99A; Tue, 23 Aug 2022 20:53:35 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0EC6968A467 for ; Tue, 23 Aug 2022 20:53:28 +0300 (EEST) Received: (Authenticated sender: michael@niedermayer.cc) by mail.gandi.net (Postfix) with ESMTPSA id 36C7720008 for ; Tue, 23 Aug 2022 17:53:27 +0000 (UTC) Date: Tue, 23 Aug 2022 19:53:27 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20220823175327.GL2088045@pb2> References: <6301fb24-1d5d-b069-a773-0defdc2086df@ycbcr.xyz> <165944996002.15471.1799609688209274723@lain.khirnov.net> <46fefbee-3ed3-77be-abf7-3a7ace9a5a61@ycbcr.xyz> MIME-Version: 1.0 In-Reply-To: <46fefbee-3ed3-77be-abf7-3a7ace9a5a61@ycbcr.xyz> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pthread_frame: update the main avctx from the current, ThreadContext X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6124089496406566246==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6124089496406566246== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QRMPWTMRwp+GIPe+" Content-Disposition: inline --QRMPWTMRwp+GIPe+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 19, 2022 at 10:07:54AM +0200, Steve Lhomme wrote: > Hi, >=20 > On 2022-08-02 16:19, Anton Khirnov wrote: > > Why are you not resubmitting your original patch that stops copying > > hwaccel_priv_data to the user-facing context? > >=20 > > It seemed more correct to me, since the user-facing context should never > > see any hwaccel data. Or does it not fix the issue fully? >=20 > The original patch is not fixing it properly. With that patch and > avcodec-threads > 1, the uninit of the hardware decoder is not called > anymore. So it will replace a crash fix with a (big) resource leak. >=20 > For reference, this it the patch we're talking about > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg94274.html Should we maybe add something to the release notes if this bug is unfixed in the next minor release ? thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin --QRMPWTMRwp+GIPe+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEIAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCYwUUFwAKCRBhHseHBAsP q9cWAJ4hCkR7eb6+VOdTVjKSgPP4G9hbLwCfaL9vPJC/IyqptKcrwpxw643ABM8= =MaWs -----END PGP SIGNATURE----- --QRMPWTMRwp+GIPe+-- --===============6124089496406566246== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6124089496406566246==--